Re: [PATCH 07/14] spi: add KUnit tests for message optimize state on queue errors

[Joseph CT Chan <jctchan@gmail.com>]

On 11/2/26 11:29 AM, David Lechner wrote:
> I was expecting a fake spi controller implementation rather than depending
> on an quirk of mem_ops to trigger the errors.

Thanks for the review. For v2 I am trying to address this with a small
change: the mem_ops controller is gone, and the test controller gets its
own transfer() that returns -EIO when a case asks for an error and
otherwise hands the message to the normal queue. That keeps one fake
controller for both the error and the retry. If you would rather see a
separate controller with its own legacy transfer() set up before
registration, let me know and I will do that instead.

> Can we get the field names here so we can see what true/false are actually
> doing?

Will do in v2, here and in the spi-mux test tables.

> Do we really need the huge AI-generated comments?

No. v2 cuts them down to one-line comments in all three test files.

Thanks,
Joseph