From: Joseph CT Chan <jctchan@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, David Lechner <dlechner@baylibre.com>,
Bart Van Assche <bvanassche@acm.org>,
Conor Dooley <conor.dooley@microchip.com>,
Joseph CT Chan <josephctchan@google.com>
Subject: [PATCH v2 3/5] spi: spi-mem: Add lock context annotations
Date: Tue, 3 Nov 2026 22:55:20 +0000 [thread overview]
Message-ID: <20261103225522.3643901-4-jctchan@gmail.com> (raw)
In-Reply-To: <20261103225522.3643901-1-jctchan@gmail.com>
From: Bart Van Assche <bvanassche@acm.org>
Annotate spi_mem_access_start() with __cond_acquires() and
spi_mem_access_end() with __releases() for both bus_lock_mutex and
io_mutex in drivers/spi/spi-mem.c. Enable static context analysis to
track controller lock ownership across SPI memory operations without
false positive lock imbalance warnings.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Joseph CT Chan <josephctchan@google.com>
---
drivers/spi/spi-mem.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index b94680b60af9..f115ef6bf53b 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -297,6 +297,8 @@ bool spi_mem_supports_op(struct spi_mem *mem, const struct spi_mem_op *op)
EXPORT_SYMBOL_GPL(spi_mem_supports_op);
static int spi_mem_access_start(struct spi_mem *mem)
+ __cond_acquires(0, &mem->spi->controller->bus_lock_mutex)
+ __cond_acquires(0, &mem->spi->controller->io_mutex)
{
struct spi_controller *ctlr = mem->spi->controller;
@@ -324,6 +326,8 @@ static int spi_mem_access_start(struct spi_mem *mem)
}
static void spi_mem_access_end(struct spi_mem *mem)
+ __releases(&mem->spi->controller->io_mutex)
+ __releases(&mem->spi->controller->bus_lock_mutex)
{
struct spi_controller *ctlr = mem->spi->controller;
--
2.56.0.385.gac671c819a-goog
next prev parent reply other threads:[~2026-11-03 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 22:55 [PATCH v2 0/5] spi: lock context annotations Joseph CT Chan
2026-11-03 22:55 ` [PATCH v2 1/5] spi: Split spi_write_then_read() Joseph CT Chan
2026-11-03 22:55 ` [PATCH v2 2/5] spi: Add lock context annotations for bus_lock_mutex Joseph CT Chan
2026-11-03 22:55 ` Joseph CT Chan [this message]
2026-11-03 22:55 ` [PATCH v2 4/5] spi: microchip-core-qspi: Add lock context annotations Joseph CT Chan
2026-11-03 22:55 ` [PATCH v2 5/5] spi: Enable lock context analysis Joseph CT Chan
2026-11-04 14:46 ` [PATCH v2 0/5] spi: lock context annotations Mark Brown
2026-11-05 4:03 ` Joseph CT Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103225522.3643901-4-jctchan@gmail.com \
--to=jctchan@gmail.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=conor.dooley@microchip.com \
--cc=dlechner@baylibre.com \
--cc=josephctchan@google.com \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox