From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6BFC433EF for ; Tue, 26 Jul 2022 09:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238436AbiGZJrX (ORCPT ); Tue, 26 Jul 2022 05:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238492AbiGZJrR (ORCPT ); Tue, 26 Jul 2022 05:47:17 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77B963204F for ; Tue, 26 Jul 2022 02:47:13 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id z25so21923929lfr.2 for ; Tue, 26 Jul 2022 02:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JG0xRZmWb8mvx5i0TSYuzFaz/yiY+cwQ7/x7y0JIQ+0=; b=eAYkTZ4sTc+PK3E0Ok2+638pi4Yw+VDFEaWLrLgw9i2SeHuFVGjZBZ+oi0fzpCGH0L TkbDzx+cV7nvJXI5zCHMM45U1BHe2cdlJxmcUXbAItFoy7zsRsnFWft9jogs+BxSyifY ItkBpzVb9TIsYt5/dfXem6cQZbOId2mxD8BcRiEIdcVf5nMaxnRVKH9kWVLXhmZoLNd2 +rnAVIgPEcx4eR7YHId0vwmPQBLGJWdE/9n9v+meAeUqT6PPZpXo9AyvgBMUp9tM6bac 85/Dch0ioAmYIqDtLGVdzXjQVK+jB8cH+DE2mA3EB+i6clSIOisOd4hIyhU0LIc+BvyH sqtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JG0xRZmWb8mvx5i0TSYuzFaz/yiY+cwQ7/x7y0JIQ+0=; b=2vs1jvibThyE7hp98HGebP5A+83hHzkFc6Qt705ueT18qAkyhV4+IzHs4mC0QVEn3E e16aQI8lOmpzZv3UVvu8tNO7ZFMuyUWIhbhT6EtK6iC/Mz11+10ZmoQpCmJRm680MSF+ P7Q3r5E6SJMHneqUSA9X0IcyH1KoGP24dt6y7NaP9ISDYv1RcoxcihoQ7LvhghjYpCnr h0noa7AIT2nezrV8rTgVW4uMvMV1Olc6zyF8r0P8PeGC/u3qF921XbdjIfGUwpXm6zlO 3Qx1wE3Yv5I9Mry0bwZLkGI3vj90nvaPPMvQX5G8mQeN6tU5MbPYYGhUBJZ4NeEkafmj GPRw== X-Gm-Message-State: AJIora+AzulwHT0ZcqIfWQKhfcZ+vltmubd1p3/2uIruHxwqqQO02l9s b0pMefCyMNvkpKY+7Rj9Z3c00Q== X-Google-Smtp-Source: AGRyM1vRwPnG7NSomcC7bgx3FgRfofno1LdnnoS0lQ7saUTLfwKfPk7rQo02FYi52y9BfWcIRZ7fOw== X-Received: by 2002:a05:6512:4020:b0:48a:8d1b:c8c3 with SMTP id br32-20020a056512402000b0048a8d1bc8c3mr3589538lfb.131.1658828831837; Tue, 26 Jul 2022 02:47:11 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id g31-20020a0565123b9f00b0047fb0d5e049sm3120559lfv.273.2022.07.26.02.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 02:47:11 -0700 (PDT) Message-ID: <20869b88-41f3-9e9c-347e-17c3d01baa5d@linaro.org> Date: Tue, 26 Jul 2022 11:47:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support Content-Language: en-US To: Tomer Maimon , Mark Brown Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , OpenBMC Maillist , linux-spi@vger.kernel.org, Linux Kernel Mailing List , devicetree References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 24/07/2022 10:44, Tomer Maimon wrote: > Hi Mark and Krzysztof, > > Thanks for your reply, > > On Fri, 22 Jul 2022 at 21:57, Mark Brown wrote: >> >> On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote: >>> On 22/07/2022 20:43, Mark Brown wrote: >> >>>> ...with a fallback list required by the bindings so the driver actually >>>> binds. Note that bindings are currently not in YAML format so there'd >>>> be even less enforcement of that than normal, and as they're currently >>>> written the bindings don't require fallback. >> >>> Yes, the bindings document should be rephrased but we were living like >>> that for few years. :) >> >> The binding document as it stands only has one compatible, there's no >> existing problem with it other than the YAML conversion. If we're >> adding something new that requires a fallback we should be explicit >> about that rather than have something that's actively misleading where >> previously things were clear. I don't mind if we add the compatible to >> the driver or document the requirement for the fallback but we should do >> one of the two. > > is V2 good enough? adding the compatible to the driver and the document? > Or should we use fallback? > If fallback is choosen, can you explain how I should do it? I propose to use fallback. The preferred way is to convert it to DT schema and then add new device support (so two commits). Other acceptable way is to rephrase the TXT so it clearly states desired compatibles - one for old device, two for new devices. There are plenty of examples in current sources. Best regards, Krzysztof