From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, Andi Shyti <andi@etezian.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Eddie James <eajames@linux.ibm.com>, Han Xu <han.xu@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 1/8] spi: s3c24xx: Fix dependencies when FIQ support is enabled
Date: Fri, 24 Feb 2023 12:05:47 +0100 [thread overview]
Message-ID: <2098f8c8-0a40-3817-bf47-5b7a2a62f5b9@linaro.org> (raw)
In-Reply-To: <20230221-spi-arch-deps-v1-1-83d1566474cf@kernel.org>
On 23/02/2023 18:20, Mark Brown wrote:
> The FIQ APIs aren't exported symbols so can't be used from modules, meaning
> that the s3c24xx driver can only have FIQ support enabled when it's built
> in.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 6fb17efb35f0..d1ee27d55a5f 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -862,7 +862,7 @@ config SPI_S3C24XX
>
> config SPI_S3C24XX_FIQ
> bool "S3C24XX driver with FIQ pseudo-DMA"
> - depends on SPI_S3C24XX
> + depends on SPI_S3C24XX=y
The entire SPI_S3C24XX driver is now being dropped (through Arnd's tree)
and should be gone by v6.3-rc1:
c9dcd56feb82 ("spi: remove s3c24xx driver")
The patch is not needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-24 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 17:20 [PATCH 0/8] spi: Build coverage cleanups and improvements Mark Brown
2023-02-23 17:20 ` [PATCH 1/8] spi: s3c24xx: Fix dependencies when FIQ support is enabled Mark Brown
2023-02-24 11:05 ` Krzysztof Kozlowski [this message]
2023-02-23 17:20 ` [PATCH 2/8] spi: rockchip: Add architecture dependency Mark Brown
2023-02-23 17:20 ` [PATCH 3/8] spi: nxp-flexspi: Fix ARCH_LAYERSCAPE dependency Mark Brown
2023-02-23 17:20 ` [PATCH 4/8] spi: davinci: Make available for build test Mark Brown
2023-02-23 17:20 ` [PATCH 5/8] spi: fsi: " Mark Brown
2023-02-23 17:20 ` [PATCH 6/8] spi: qcom-qspi: " Mark Brown
2023-02-23 17:20 ` [PATCH 7/8] spi: s3c24xx: Only have compile time references to FIQ when building it Mark Brown
2023-02-24 11:06 ` Krzysztof Kozlowski
2023-02-23 17:20 ` [PATCH 8/8] spi: s3c24xx: Allow build test coverage Mark Brown
2023-03-06 13:32 ` [PATCH 0/8] spi: Build coverage cleanups and improvements Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2098f8c8-0a40-3817-bf47-5b7a2a62f5b9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=eajames@linux.ibm.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=heiko@sntech.de \
--cc=konrad.dybcio@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).