Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Chi-Wen Weng <cwweng.linux@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	cwweng@nuvoton.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: spi: nuvoton,ma35d1-qspi: Add Nuvoton MA35D1 QSPI
Date: Mon, 3 Aug 2026 10:06:12 +0800	[thread overview]
Message-ID: <222f1bd8-e680-4a45-a7b3-d6e8b653c2a8@gmail.com> (raw)
In-Reply-To: <5769eae0-1b40-419f-8311-0d919bf619fa@sirena.org.uk>


Mark Brown 於 2026/8/1 上午 04:28 寫道:
> On Fri, Jul 31, 2026 at 10:38:17AM +0800, Chi-Wen Weng wrote:
>> From: Chi-Wen Weng <cwweng@nuvoton.com>
>>
>> Add a devicetree binding for the Quad SPI controller found in
>> Nuvoton MA35D1 SoCs.
> This leaves the generic binding's support for GPIO chip selects enabled
> but the driver doesn't set use_gpio_descriptors so they don't actually
> work.  Either the binding or the driver needs an update.  Otherwise
> things seem mostly OK so I'll apply, please send an incremental patch
> for this.

Hi Mark,

Thanks for pointing this out and for applying the series.

The current driver only supports the controller's native chip selects, 
so I will send an incremental binding patch to disallow the cs-gpios 
property.

Best regards,
Chi-Wen


  reply	other threads:[~2026-08-03  2:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  2:38 [PATCH v5 0/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller Chi-Wen Weng
2026-07-31  2:38 ` [PATCH v5 1/2] dt-bindings: spi: nuvoton,ma35d1-qspi: Add Nuvoton MA35D1 QSPI Chi-Wen Weng
2026-07-31 20:28   ` Mark Brown
2026-08-03  2:06     ` Chi-Wen Weng [this message]
2026-08-03  6:24     ` [PATCH v2] spi: ma35d1-qspi: Enable GPIO chip selects Chi-Wen Weng
2026-08-03  7:49     ` [PATCH v3 0/2] spi: ma35d1-qspi: Enable GPIO chip-select support Chi-Wen Weng
2026-08-03  7:49       ` [PATCH v3 1/2] dt-bindings: spi: nuvoton,ma35d1-qspi: Allow additional GPIO chip selects Chi-Wen Weng
2026-08-04  7:05         ` Krzysztof Kozlowski
2026-08-04  7:33           ` Chi-Wen Weng
2026-08-03  7:49       ` [PATCH v3 2/2] spi: ma35d1-qspi: Enable " Chi-Wen Weng
2026-08-03 12:30       ` [PATCH v3 0/2] spi: ma35d1-qspi: Enable GPIO chip-select support Mark Brown
2026-08-04  1:57         ` Chi-Wen Weng
2026-07-31  2:38 ` [PATCH v5 2/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller support Chi-Wen Weng
2026-07-31 20:29 ` [PATCH v5 0/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=222f1bd8-e680-4a45-a7b3-d6e8b653c2a8@gmail.com \
    --to=cwweng.linux@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cwweng@nuvoton.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox