From: Heiko Stuebner <heiko@sntech.de>
To: linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org,
Dragan Simic <dsimic@manjaro.org>
Cc: broonie@kernel.org, oss@helene.moe,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] spi: rockchip: Don't check for failed get_fifo_len()
Date: Thu, 26 Sep 2024 10:55:01 +0200 [thread overview]
Message-ID: <2382990.BjyWNHgNrj@phil> (raw)
In-Reply-To: <ce2e7f90e62b15adc2bed1f53122ad39c3a9b5ac.1727337732.git.dsimic@manjaro.org>
Am Donnerstag, 26. September 2024, 10:38:14 CEST schrieb Dragan Simic:
> Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs"),
> function get_fifo_len() can no longer return zero, so delete the redundant
> check for zero in function rockchip_spi_probe().
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Didn't this topic come up in another recent patch too?
Anyway, having looked up the what the current get_fifo_len does,
the 0 case should never happen, as you describe, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2024-09-26 8:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 8:38 [PATCH 0/5] Improve error handling in Rockchip SPI drivers Dragan Simic
2024-09-26 8:38 ` [PATCH 1/5] spi: rockchip: Perform trivial code cleanups Dragan Simic
2024-09-26 8:52 ` Heiko Stuebner
2024-09-26 8:38 ` [PATCH 2/5] spi: rockchip-sfc: " Dragan Simic
2024-09-26 8:53 ` Heiko Stuebner
2024-09-26 8:38 ` [PATCH 3/5] spi: rockchip: Don't check for failed get_fifo_len() Dragan Simic
2024-09-26 8:55 ` Heiko Stuebner [this message]
2024-09-26 9:10 ` Dragan Simic
2024-09-26 9:17 ` Mark Brown
2024-09-26 10:14 ` Dragan Simic
2024-09-26 8:38 ` [PATCH 4/5] spi: rockchip: Use dev_err_probe() in the probe path Dragan Simic
2024-09-26 9:00 ` Heiko Stuebner
2024-09-26 9:21 ` Dragan Simic
2024-09-26 8:38 ` [PATCH 5/5] spi: rockchip-sfc: " Dragan Simic
2024-09-26 9:01 ` Heiko Stuebner
2024-09-30 23:51 ` (subset) [PATCH 0/5] Improve error handling in Rockchip SPI drivers Mark Brown
2024-10-01 0:05 ` Diederik de Haas
2024-10-01 2:30 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2382990.BjyWNHgNrj@phil \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=dsimic@manjaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=oss@helene.moe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).