linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Brüns, Stefan" <Stefan.Bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
To: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/2] Fix displays requiring 9 bit transfers on RPi
Date: Tue, 18 Aug 2015 20:41:55 +0000	[thread overview]
Message-ID: <2396767.SsPboNIpj6@sbruens-linux> (raw)
In-Reply-To: <1439278071-21110-1-git-send-email-stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>

Hi,

any comments on these two patches, please?

Kind regards,

Stefan


On Tuesday, August 11, 2015 09:27:49 you wrote:
> Some displays need 9 bit long SPI transfers (Command/Data flag plus
> 8 bit data). FBTFT has emulation code in case the controller only
> supports 8 bit transfers, but this is only used if the controller
> setup function report an error if bits_per_word is set to 9.
> 
> Report unsupported bits_per_word settings in spi_setup Currently the
> SPI core only checks bits_per_word on transfer, but not on setup.
> 
> Replace invocations of master->setup(...) with spi_setup(...).
> 
> Tested on RPi B with an Ilitek9341 based TFT display in 9 bit mode.
> 
> Stefan Brüns (2):
>   spi: check bits_per_word in spi_setup
>   staging/fbtft: use spi_setup instead of direct call to master->setup
> 
>  drivers/spi/spi.c                    | 27 +++++++++++++++++++--------
>  drivers/staging/fbtft/fb_watterott.c |  4 ++--
>  drivers/staging/fbtft/fbtft-core.c   |  4 ++--
>  drivers/staging/fbtft/flexfb.c       |  4 ++--
>  4 files changed, 25 insertions(+), 14 deletions(-)

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019
work: +49 2405 49936-424--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-18 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1439278071-21110-1-git-send-email-stefan.bruens@rwth-aachen.de>
     [not found] ` <1439278071-21110-1-git-send-email-stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
2015-08-11  7:27   ` [PATCH 1/2] spi: check bits_per_word in spi_setup Stefan Brüns
2015-08-11  7:27   ` [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup Stefan Brüns
2015-08-15 18:30   ` [PATCH 0/2] Fix displays requiring 9 bit transfers on RPi Stefan Bruens
2015-08-18 20:41   ` Brüns, Stefan [this message]
2015-08-11  7:27 Stefan Brüns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2396767.SsPboNIpj6@sbruens-linux \
    --to=stefan.bruens-va1bhqpz9fbzxben9dutxg@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).