From: Marek Vasut <marek.vasut@gmail.com>
To: Mason Yang <masonccyang@mxic.com.tw>,
broonie@kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, bbrezillon@kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
sergei.shtylyov@cogentembedded.com, devicetree@vger.kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org, lee.jones@linaro.org
Cc: juliensu@mxic.com.tw, Simon Horman <horms@verge.net.au>,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Fri, 29 Mar 2019 11:44:51 +0100 [thread overview]
Message-ID: <2741fba1-9aab-d044-15db-54d09e12d309@gmail.com> (raw)
In-Reply-To: <1553847606-18122-3-git-send-email-masonccyang@mxic.com.tw>
On 3/29/19 9:20 AM, Mason Yang wrote:
[...]
> +struct rpc_spi {
> + struct clk *clk_rpc;
> + void __iomem *base;
> + void __iomem *dirmap;
> + void __iomem *wbuf;
Shouldn't all this stuff somehow come from the MFD driver ?
> + struct regmap *regmap;
> + u32 cur_speed_hz;
> + u32 cmd;
> + u32 addr;
> + u32 dummy;
> + u32 smcr;
> + u32 smenr;
> + u32 xferlen;
> + u32 totalxferlen;
> + enum spi_mem_data_dir xfer_dir;
> + struct reset_control *rstc;
> +};
> +
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-03-29 10:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:20 [PATCH v9 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-03-29 8:20 ` [PATCH v9 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD controller driver Mason Yang
2019-03-29 10:43 ` Marek Vasut
2019-03-29 15:12 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI " Mason Yang
2019-03-29 10:44 ` Marek Vasut [this message]
2019-03-29 15:52 ` Sergei Shtylyov
[not found] ` <OF7F1B534F.B934A9FE-ON482583D0.001DC618-482583D0.001FE84B@mxic.com.tw>
2019-04-02 20:10 ` Sergei Shtylyov
[not found] ` <OFAEA16021.C7F7B095-ON482583D1.0031A13D-482583D1.00335085@mxic.com.tw>
2019-04-04 18:56 ` Sergei Shtylyov
2019-04-04 19:12 ` Boris Brezillon
2019-04-06 19:59 ` Sergei Shtylyov
2019-04-09 11:20 ` Sergei Shtylyov
2019-04-10 19:47 ` Sergei Shtylyov
2019-04-09 20:07 ` Sergei Shtylyov
[not found] ` <OFC7F0028A.CFF6BD04-ON482583D8.00084FA1-482583D8.0008985F@mxic.com.tw>
2019-04-10 6:27 ` Marek Vasut
[not found] ` <OF75EDBF48.5C308F1B-ON482583D8.0027A537-482583D8.002C0A64@mxic.com.tw>
2019-04-10 8:03 ` Marek Vasut
2019-04-10 8:11 ` Boris Brezillon
2019-04-10 17:53 ` Sergei Shtylyov
2019-04-13 16:38 ` Sergei Shtylyov
2019-04-13 16:39 ` Sergei Shtylyov
[not found] ` <OF82CE76E9.E6395EF7-ON482583DD.000E37D7-482583DD.000E5077@mxic.com.tw>
2019-04-17 18:44 ` Sergei Shtylyov
[not found] ` <OF4ABCC306.B053BA23-ON482583E0.000F480C-482583E0.000FAD4A@mxic.com.tw>
2019-04-18 19:43 ` Sergei Shtylyov
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@LocalDomain>
[not found] ` <OFE74649D4.F69BB5EF-ON482583E1.0033F73F-482583E1.00344ED2@mxic.com.tw>
2019-04-22 16:44 ` Sergei Shtylyov
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@mxic.com.tw>
2019-04-23 7:29 ` Geert Uytterhoeven
2019-05-14 19:06 ` Sergei Shtylyov
2019-05-14 19:13 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-03-29 10:45 ` Marek Vasut
2019-03-29 10:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2741fba1-9aab-d044-15db-54d09e12d309@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).