From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Mark Brown <broonie@kernel.org>, Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit
Date: Mon, 12 Feb 2018 12:04:34 -0600 [thread overview]
Message-ID: <275feee3-7140-498b-714f-4c88a302d3f6@embeddedor.com> (raw)
In-Reply-To: <CAKv+Gu9hmxLSS0ekr8av-ADt3OQjBV=Bt-hRq_-SzWaGODs4SQ@mail.gmail.com>
Hi Ard,
On 02/08/2018 03:54 AM, Ard Biesheuvel wrote:
> On 7 February 2018 at 16:00, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>> Add suffix ULL to constant 9 in order to give the compiler complete
>> information about the proper arithmetic to use. Notice that this
>> constant is used in a context that expects an expression of type
>> unsigned long long (64 bits, unsigned).
>>
>> The expression tfr->len * 9 * 1000000 is currently being evaluated
>> using 32-bit arithmetic.
>>
>> Addresses-Coverity-ID: 1339619
>
> What does this number mean? If it is an index into some internal
> database, please remove it.
>
This is a unique Coverity identifier. We want to keep information like
public Bugzilla IDs and tools like Coverity on the commit message.
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-02-12 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 16:00 [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit Gustavo A. R. Silva
2018-02-08 8:22 ` Eric Anholt
2018-02-12 17:57 ` Gustavo A. R. Silva
2018-02-08 9:54 ` Ard Biesheuvel
2018-02-12 18:04 ` Gustavo A. R. Silva [this message]
2018-02-12 18:45 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9VTkNN-6MCCuQ2jWFyDMeZKNRyPqMpTWB5jvuSw7MWeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-12 19:10 ` Florian Fainelli
[not found] ` <bab99bbb-c84b-3413-e7f8-203c7daad8b3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-12 19:11 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9Mb7Wpzwvr=1WsUs1jXYT16DL2dYBfhSWH0HYZMYM5Nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-12 19:14 ` Florian Fainelli
2018-02-12 19:31 ` Trent Piepho
2018-02-12 19:38 ` [PATCH] spi: bcm2835aux: Avoid 64-bit arithmetic in xfer len calc Trent Piepho
[not found] ` <20180212193814.17644-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2018-02-14 16:04 ` Mark Brown
2018-02-14 16:28 ` Applied "spi: bcm2835aux: Avoid 64-bit arithmetic in xfer len calc" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=275feee3-7140-498b-714f-4c88a302d3f6@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).