From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Cc: quic_msavaliy@quicinc.com, dianders@chromium.org,
mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com
Subject: Re: [V2 1/3] spi: dt-bindings: qcom,spi-qcom-qspi: Add iommus binding for qspi
Date: Wed, 12 Apr 2023 18:01:45 +0200 [thread overview]
Message-ID: <28488550-7d5a-232c-c9d9-9ca82acfb0f9@linaro.org> (raw)
In-Reply-To: <1681313387-8376-2-git-send-email-quic_vnivarth@quicinc.com>
On 12/04/2023 17:29, Vijaya Krishna Nivarthi wrote:
> Add iommus binding to documentation to be in sync with below
> change to dtsi...
> Add stream-id of qspi to iommus
This commit msg needs improvements. Try to avoid referring to other
patches in the series, unless necessary. In this case - it is not
necessary. You should provide here rationale for the binding change.
Subject: Drop redundant part "binding for qspi"
You also miss PATCH part. Use standard tools to generate patches, so
they will fit properly to Linux patch workflow.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-12 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:29 [V2 0/3] spi: Add DMA mode support to spi-qcom-qspi Vijaya Krishna Nivarthi
2023-04-12 15:29 ` [V2 1/3] spi: dt-bindings: qcom,spi-qcom-qspi: Add iommus binding for qspi Vijaya Krishna Nivarthi
2023-04-12 16:01 ` Krzysztof Kozlowski [this message]
2023-04-12 15:29 ` [V2 2/3] arm64: dts: qcom: sc7280: Add stream-id of qspi to iommus Vijaya Krishna Nivarthi
2023-04-12 16:02 ` Krzysztof Kozlowski
2023-04-12 15:29 ` [V2 3/3] spi: spi-qcom-qspi: Add DMA mode support Vijaya Krishna Nivarthi
2023-04-12 16:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28488550-7d5a-232c-c9d9-9ca82acfb0f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).