From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8226C43381 for ; Wed, 20 Jan 2021 15:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 628772336D for ; Wed, 20 Jan 2021 15:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390499AbhATPKf (ORCPT ); Wed, 20 Jan 2021 10:10:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58023 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390953AbhATPFO (ORCPT ); Wed, 20 Jan 2021 10:05:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611155027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLkTnoEhhqT5XnK+V0Ri+zXEP8mtFMltsuZRc1io4Mo=; b=C9Msq6DDbsdV64K16bJvg511xxqMo6cHXVeRzmGGBspEKlpi9eUbh8VjwUVS+0iz9kbFXU AIXZIZeIkfsYOD29bNYAHwl1+/bk4DV8c5uu7RpJphWIAl+KLexE+qX2gQcwcNkYO8N6LO BMYSiPh2NvAGTjoLiPEaPeST7Ad2p/8= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-Uvt78s-fMvOilLWfimF-KQ-1; Wed, 20 Jan 2021 10:03:45 -0500 X-MC-Unique: Uvt78s-fMvOilLWfimF-KQ-1 Received: by mail-qv1-f70.google.com with SMTP id k16so23393075qve.19 for ; Wed, 20 Jan 2021 07:03:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DLkTnoEhhqT5XnK+V0Ri+zXEP8mtFMltsuZRc1io4Mo=; b=bYan7Fvkwv8ERBHCY1AsZ4WNTF7XmKH9IYRiKPI7jOj5tFLDSvA6LV8lDFfqXZBNAn za9dnULsQTLbQSFVizYn3UfFuSse2XRc/zailaoANiywxHtv6GftSouVuK91sHoldU7q peXQjs+i6EycC31LpOAiMp/mYxHaWGOAVvEmDtTqIj3zZ0c5YFpwd60mzM1t+WBCCWwG ftjgD8cTW8cK6HlLhZ0cON7RTSbGbzr4KF/nJUsYgZRCXkddRdlE5Y0D4jhUDq1rgYMe 1Zew7Z/bjSrYFwxPiwNKDUfHItv76koGwc8/5T9AfeXwUGQkVY1zUNEWWfrlJaZ/lMG9 EWhw== X-Gm-Message-State: AOAM531b39lmTpMZP4OP/+a09jgHLvgLGjeekbeCUEMouast5mm7y7W8 OIoEzHLrc3NJdKsCogG4ssEl1xUpYOldCnVN98nRW93mzKJuSn7ItvCUc2taN5PoOGNfCefBnBY UMlwlYNWvjDse/JREprHx X-Received: by 2002:a37:9f14:: with SMTP id i20mr9933237qke.321.1611155024820; Wed, 20 Jan 2021 07:03:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1NgZWfa0FoCcv72Jr91hrje7OB2eR1AjLOB6y9Mz3IUwCYNr1bPZ94I/AV1xVad9LFx/jWA== X-Received: by 2002:a37:9f14:: with SMTP id i20mr9933207qke.321.1611155024575; Wed, 20 Jan 2021 07:03:44 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id b78sm1477745qkg.29.2021.01.20.07.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 07:03:43 -0800 (PST) Subject: Re: [PATCH] spi: altera: Fix memory leak on error path To: Pan Bian , Mark Brown , Xu Yilun , Matthew Gerlach , Wu Hao Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210120082635.49304-1-bianpan2016@163.com> From: Tom Rix Message-ID: <29bc2be2-911e-e892-4d1c-cc5c8ce10571@redhat.com> Date: Wed, 20 Jan 2021 07:03:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120082635.49304-1-bianpan2016@163.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 1/20/21 12:26 AM, Pan Bian wrote: > Release master that have been previously allocated if the number of > chipselect is invalid. > > Fixes: 8e04187c1bc7 ("spi: altera: add SPI core parameters support via platform data.") > Signed-off-by: Pan Bian > --- > drivers/spi/spi-altera.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c > index cbc4c28c1541..62ea0c9e321b 100644 > --- a/drivers/spi/spi-altera.c > +++ b/drivers/spi/spi-altera.c > @@ -254,7 +254,8 @@ static int altera_spi_probe(struct platform_device *pdev) > dev_err(&pdev->dev, > "Invalid number of chipselect: %hu\n", > pdata->num_chipselect); > - return -EINVAL; > + err = -EINVAL; > + goto exit; > } > > master->num_chipselect = pdata->num_chipselect; Reviewed-by: Tom Rix