From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Nikita Shubin <nikita.shubin@maquefel.me>,
Arnd Bergmann <arnd@arndb.de>
Cc: kernel test robot <lkp@intel.com>, Vinod Koul <vkoul@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi
Date: Thu, 12 Sep 2024 15:45:11 +0200 [thread overview]
Message-ID: <2bf46273a071cc90e3b33c08bbb0fad475b6e0ef.camel@gmail.com> (raw)
In-Reply-To: <20240912132126.2991851-1-arnd@kernel.org>
On Thu, 2024-09-12 at 13:21 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two fields got removed but are still documented:
>
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_rx_data' description in 'ep93xx_spi'
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_tx_data' description in 'ep93xx_spi'
>
> Fixes: 3cfe73256905 ("spi: ep93xx: add DT support for Cirrus EP93xx")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> I've added this fixup in the ep93xx/dt-conversion branch
>
> drivers/spi/spi-ep93xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index ffbe0d522bce..dc6bdc74643d 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -76,8 +76,6 @@
> * frame decreases this level and sending one frame increases it.
> * @dma_rx: RX DMA channel
> * @dma_tx: TX DMA channel
> - * @dma_rx_data: RX parameters passed to the DMA engine
> - * @dma_tx_data: TX parameters passed to the DMA engine
> * @rx_sgt: sg table for RX transfers
> * @tx_sgt: sg table for TX transfers
> * @zeropage: dummy page used as RX buffer when only TX buffer is passed in by
--
Alexander Sverdlin.
prev parent reply other threads:[~2024-09-12 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 13:21 [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi Arnd Bergmann
2024-09-12 13:45 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bf46273a071cc90e3b33c08bbb0fad475b6e0ef.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox