From: Thor Thayer <tthayer@opensource.altera.com>
To: Mark Brown <broonie@kernel.org>
Cc: <andriy.shevchenko@linux.intel.com>,
<jarkko.nikula@linux.intel.com>, <jszhang@marvell.com>,
<michael@smart-africa.com>, <kernel@mseidel.net>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: dw: Enable Slave Select with GPIO Chip Select.
Date: Thu, 6 Oct 2016 09:15:02 -0500 [thread overview]
Message-ID: <2df0001c-dd59-1352-f5be-a22a9798a357@opensource.altera.com> (raw)
In-Reply-To: <20161006093755.kv6tondkeauu5oz2@sirena.org.uk>
On 10/06/2016 04:37 AM, Mark Brown wrote:
> On Wed, Oct 05, 2016 at 04:38:58PM -0500, tthayer@opensource.altera.com wrote:
>
>> This patch adds the Slave Select locally so that the transfer will
>> start and complete. The GPIO CS is taken care of earlier in the SPI
>> framework (spi_set_cs).
>
> This seems like something that other devices might need - it's not the
> first time I heard of a device with the data transfer start and chip
> select being tied together. Why not make this a generic feature that
> the core implements and drivers can enable?
>
OK. Thanks for the suggestion and review. I'll add a new boolean and
device tree binding to the SPI core. Thanks.
prev parent reply other threads:[~2016-10-06 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 21:38 [PATCH] spi: dw: Enable Slave Select with GPIO Chip Select tthayer
[not found] ` <1475703538-5018-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-06 9:37 ` Mark Brown
2016-10-06 14:15 ` Thor Thayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df0001c-dd59-1352-f5be-a22a9798a357@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=kernel@mseidel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@smart-africa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).