From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5618143AA9; Mon, 27 Jan 2025 06:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737961098; cv=none; b=DF9iB04kDIRq5jHgJGKdWzRZq4pfyihRqQwIs27rX8WPMHeGze2tt2PN77pRMt55PRyao0v8GES8Ds+1oDtTCtayQeEhBhm6YjOINPrKevcXEj2/vngxAKcrCKhDDxda13x9FYYoaxMybxirOZS2pCoRiyqDVUiFtejXoJC9x30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737961098; c=relaxed/simple; bh=yGZewy6ZlY42LYpqKTQGCK96RH/vtFrL+3JX4UsMsxg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UabNFT4lpE6M2e8qkDaeXKaNETxGyFVdGmZ7MRAbHV6b6i9mFDaWGS1yfJOt77B0VkmnSXW0D4R8HZ0qgt+6nL/QdZd6YyPmcrNUvv31uATSurlwyZJsdU2aEg95eumopVIbViAc7qM3lYn5aA03lHDxwS7YOEXnwdMaTtG5C08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=glMKjfxE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="glMKjfxE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED64BC4CED2; Mon, 27 Jan 2025 06:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737961098; bh=yGZewy6ZlY42LYpqKTQGCK96RH/vtFrL+3JX4UsMsxg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=glMKjfxEyRTQgl+k8epZmUV0vMpQc9zbMJFTvu8IqZe2yMvSo8MG0dPRXUXVlLBbU 8ww83qJbtIDcCqSQChArZyCsCVyL0Jk94CX9y1Rj5jIRi58wdRNIIYjsYURWNTvV0A VhYsMiqO70HIlz6QA53yMi0o+K1dewcKXQXFhxDEcouraLCvITYOXjX23tmiztQlRk Me/Vey+NIFPCVEpHbdwgi6+iU2zynvLSxx3KH1OvNnc8lEygwWiLj3NFS8oIcW06dU zkb8R0QjAuaHGr/MH4YeC3V1AWjYXLXEGbAgkSGqXRbYNkwXr2smZ5AS3mKmc1HlwT 4ZZuM0oZSQaSQ== Message-ID: <2ef6561c-d5ba-40d9-a085-fdced597233f@kernel.org> Date: Mon, 27 Jan 2025 07:58:08 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] dt-bindings: i2c: qcom,i2c-geni: Add support for selecting data transfer mode To: Viken Dadhaniya , Dmitry Baryshkov Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, broonie@kernel.or, andersson@kernel.org, konradybcio@kernel.org, johan+linaro@kernel.org, dianders@chromium.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, quic_msavaliy@quicinc.com, quic_anupkulk@quicinc.com References: <20250124105309.295769-1-quic_vdadhani@quicinc.com> <20250124105309.295769-3-quic_vdadhani@quicinc.com> <38d24c6b-369e-4254-ae50-5387e2b6063e@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <38d24c6b-369e-4254-ae50-5387e2b6063e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/01/2025 16:16, Viken Dadhaniya wrote: > > > On 1/24/2025 8:33 PM, Dmitry Baryshkov wrote: >> On Fri, Jan 24, 2025 at 05:52:24PM +0530, Viken Dadhaniya wrote: >>> >>> >>> On 1/24/2025 4:48 PM, Dmitry Baryshkov wrote: >>>> On Fri, Jan 24, 2025 at 04:23:03PM +0530, Viken Dadhaniya wrote: >>>>> Data transfer mode is fixed by TrustZone (TZ), which currently restricts >>>>> developers from modifying the transfer mode from the APPS side. >>>>> >>>>> Document the 'qcom,xfer-mode' properties to select the data transfer mode, >>>>> either GPI DMA (Generic Packet Interface) or non-GPI mode (PIO/CPU DMA). >>>>> >>>>> I2C controller can operate in one of two modes based on the >>>>> 'qcom,xfer-mode' property, and the firmware is loaded accordingly. >>>> >>>> Is it possible to load the firmware after it being loaded by TZ? Is it >>>> possible to change the mode at runtime too? >>> >>> No, firmware can be loaded either from the TZ side or APPS side. >> >> You answer actually reads as "No, yes" (excuse me, non-native here). >> Most likely you mean that it can not be reloaded once either TZ or APPS >> has loaded it. > > Yes correct. it can not be reloaded once either TZ or APPS has loaded it. > >> >>> In non-GPI mode, the transfer mode will change runtime between PIO and CPU >>> DMA based on the data length. >>> >>> We need to update the device tree property(qcom,xfer-mode) to change the >>> mode between non-GPI and GPI. >> >> So, is it actually possible to change the mode? E.g. if the TZ has >> loaded the firmware and configured SE for PIO/SE DMA, is it possible to >> change it to GPI DMA? > > No, if the TZ has loaded the firmware, it is not possible to switch from > non-GPI (PIO/SE DMA) to GPI DMA mode. > >> >>> >>>> >>>>> >>>>> Co-developed-by: Mukesh Kumar Savaliya >>>>> Signed-off-by: Mukesh Kumar Savaliya >>>>> Signed-off-by: Viken Dadhaniya >>>>> --- >>>>> >>>>> v1 -> v2: >>>>> >>>>> - Drop 'qcom,load-firmware' property and add 'firmware-name' property in >>>>> qup common driver. >>>>> - Update commit log. >>>>> >>>>> v1 Link: https://lore.kernel.org/linux-kernel/20241204150326.1470749-2-quic_vdadhani@quicinc.com/ >>>>> --- >>>>> --- >>>>> .../devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 7 +++++++ >>>>> 1 file changed, 7 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>>>> index 9f66a3bb1f80..68e4bf0c84d1 100644 >>>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>>>> @@ -66,6 +66,12 @@ properties: >>>>> required-opps: >>>>> maxItems: 1 >>>>> + qcom,xfer-mode: >>>>> + description: Set the value to 1 for non-GPI (FIFO/CPU DMA) mode and 3 for GPI DMA mode. >>>>> + The default mode is FIFO. >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + enum: [1, 3] >>>>> + >>>>> required: >>>>> - compatible >>>>> - interrupts >>>>> @@ -142,5 +148,6 @@ examples: >>>>> interconnect-names = "qup-core", "qup-config", "qup-memory"; >>>>> power-domains = <&rpmhpd SC7180_CX>; >>>>> required-opps = <&rpmhpd_opp_low_svs>; >>>>> + qcom,xfer-mode = <1>; >>>> >>>> What does <1> mean? Please provide corresponding defines. >>> >>> Do we need to add a string instead of a number, like >>> include/dt-bindings/dma/qcom-gpi.h? >> >> You need to '#define FOO_BAR 1', then another one for 3. String is a >> "string", it's not required here (in my opinion). >> > > Sure, I will update it in the next patch. Well, no. Not 3 but 2, because why having gap there? But anyway use string and explain what is GPI. I assume that DMA is present in both cases, you just choose not to use it? If so, then why? Best regards, Krzysztof