From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Ye Xiang" <xiang.ye@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Lee Jones" <lee@kernel.org>, "Wolfram Sang" <wsa@kernel.org>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
zhifeng.wang@intel.com, wentong.wu@intel.com,
lixu.zhang@intel.com
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Date: Thu, 09 Mar 2023 12:30:33 +0100 [thread overview]
Message-ID: <2fffffcb-4f76-405b-acba-1b2e744d75c4@app.fastmail.com> (raw)
In-Reply-To: <8e3c16a7-1155-419c-9bcb-cc3e3630fe5b@sirena.org.uk>
On Thu, Mar 9, 2023, at 12:03, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 08:56:05AM +0100, Arnd Bergmann wrote:
>> On Thu, Mar 9, 2023, at 08:10, Ye Xiang wrote:
>
>> > drivers/usb/misc/Kconfig | 13 +
>> > drivers/usb/misc/Makefile | 1 +
>> > drivers/usb/misc/ljca.c | 969 ++++++++++++++++++++++++++++++++++++++
>> > include/linux/mfd/ljca.h | 95 ++++
>
>> Why is this in driver/usb/misc? It looks like a normal
>> mfd driver to me, and it evenhas the header in include/linux/mfd/
>
> It was a MFD in the original version, Lee asked for it to be moved to
> USB: https://lore.kernel.org/r/20230305103456.GF2574592@google.com
Ok, I see. That should probably be mentioned in the patch
description then. I'm still not sure I follow the reasoning
for the split between "usb functionality" and and mfd part:
This is just a usb driver as it is attached to a usb bus, and
drivers usually get put into a directory based on what they
provide, not how they are attached to a parent bus.
Arnd
next prev parent reply other threads:[~2023-03-09 11:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 7:10 [PATCH v4 0/5] Add Intel LJCA device driver Ye Xiang
2023-03-09 7:10 ` [PATCH v4 1/5] mfd: Add support for Intel LJCA device Ye Xiang
2023-03-09 7:49 ` Greg Kroah-Hartman
2023-03-09 9:10 ` Ye, Xiang
2023-03-09 9:26 ` Greg Kroah-Hartman
2023-03-09 10:16 ` Ye, Xiang
2023-03-09 7:52 ` Greg Kroah-Hartman
2023-03-09 9:31 ` Ye, Xiang
2023-03-09 9:41 ` Greg Kroah-Hartman
2023-03-09 10:06 ` Andi Shyti
2023-03-09 15:45 ` Ye, Xiang
2023-03-09 15:58 ` Greg Kroah-Hartman
2023-03-09 17:42 ` Ye, Xiang
2023-03-09 7:56 ` Arnd Bergmann
2023-03-09 10:00 ` Ye, Xiang
2023-03-09 11:03 ` Mark Brown
2023-03-09 11:30 ` Arnd Bergmann [this message]
2023-03-09 12:53 ` Oliver Neukum
2023-03-10 4:14 ` Ye, Xiang
2023-03-13 13:27 ` Oliver Neukum
2023-03-14 7:15 ` Ye, Xiang
2023-03-09 7:10 ` [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-03-09 13:40 ` Oliver Neukum
2023-03-09 13:52 ` Andy Shevchenko
2023-03-09 14:06 ` Greg Kroah-Hartman
2023-03-09 14:18 ` Linus Walleij
2023-03-09 14:36 ` Greg Kroah-Hartman
2023-03-09 14:48 ` Arnd Bergmann
2023-03-09 17:37 ` Oliver Neukum
2023-03-09 17:30 ` Oliver Neukum
2023-03-10 5:01 ` Ye, Xiang
2023-03-10 7:11 ` Greg Kroah-Hartman
2023-03-10 7:39 ` Ye, Xiang
2023-03-10 7:53 ` Greg Kroah-Hartman
2023-03-10 8:59 ` Ye, Xiang
2023-03-11 12:13 ` Krzysztof Kozlowski
2023-03-12 15:40 ` Ye, Xiang
2023-03-09 7:10 ` [PATCH v4 3/5] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-03-09 7:10 ` [PATCH v4 4/5] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
2023-03-09 7:11 ` [PATCH v4 5/5] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fffffcb-4f76-405b-acba-1b2e744d75c4@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=mka@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=wsa@kernel.org \
--cc=xiang.ye@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).