* [PATCH] spi: bcm53xx: add BCMA dependency
@ 2014-09-30 12:09 Arnd Bergmann
2014-09-30 12:13 ` Rafał Miłecki
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2014-09-30 12:09 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Rafał Miłecki
The BCMA bus framework can be disabled on bcm53xx, which leads to a link
error when building the SPI driver:
drivers/built-in.o: In function `bcm53xxspi_module_init':
:(.init.text+0x76d4): undefined reference to `__bcma_driver_register'
drivers/built-in.o: In function `bcm53xxspi_module_exit':
:(.exit.text+0x10fe): undefined reference to `bcma_driver_unregister'
To avoid that, this adds an explicit dependency on BCMA. While we're
changing the dependencies, let's also add a COMPILE_TEST option, which
will of course not have any effect unless building on another machine
that has BCMA enabled.
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Fixes: 0fc6a323e19 ("spi: bcm53xx: driver for SPI controller on Broadcom bcma SoC")
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index bb7b5ec000d9..ababd27a4211 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -115,7 +115,8 @@ config SPI_AU1550
config SPI_BCM53XX
tristate "Broadcom BCM53xx SPI controller"
- depends on ARCH_BCM_5301X
+ depends on ARCH_BCM_5301X || COMPILE_TEST
+ depends on BCMA
help
Enable support for the SPI controller on Broadcom BCM53xx ARM SoCs.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: bcm53xx: add BCMA dependency
2014-09-30 12:09 [PATCH] spi: bcm53xx: add BCMA dependency Arnd Bergmann
@ 2014-09-30 12:13 ` Rafał Miłecki
[not found] ` <CACna6ryoq0A_6745aemJPQTEZxncmDRkCOPB3ZUHtNhXqXf2Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2014-09-30 12:13 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, linux-spi, Linux Kernel Mailing List,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On 30 September 2014 14:09, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> The BCMA bus framework can be disabled on bcm53xx, which leads to a link
> error when building the SPI driver:
You missed this one:
https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: bcm53xx: add BCMA dependency
[not found] ` <CACna6ryoq0A_6745aemJPQTEZxncmDRkCOPB3ZUHtNhXqXf2Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-09-30 12:15 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-09-30 12:15 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Rafał Miłecki, Mark Brown, Linux Kernel Mailing List,
linux-spi
On Tuesday 30 September 2014 14:13:35 Rafał Miłecki wrote:
> On 30 September 2014 14:09, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> > The BCMA bus framework can be disabled on bcm53xx, which leads to a link
> > error when building the SPI driver:
>
> You missed this one:
> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
>
Right, I'm still catching up with last week's build regressions.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-30 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 12:09 [PATCH] spi: bcm53xx: add BCMA dependency Arnd Bergmann
2014-09-30 12:13 ` Rafał Miłecki
[not found] ` <CACna6ryoq0A_6745aemJPQTEZxncmDRkCOPB3ZUHtNhXqXf2Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-30 12:15 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).