From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: YANG LI <abaci-bugfix@linux.alibaba.com>,
kdasu.kdev@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison
Date: Mon, 11 Jan 2021 09:21:11 -0800 [thread overview]
Message-ID: <32b6ba61-91a8-ada3-1c8f-0e85d330f27e@gmail.com> (raw)
In-Reply-To: <20210111170556.GF4728@sirena.org.uk>
On 1/11/21 9:05 AM, Mark Brown wrote:
> On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote:
>
>>> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
>>> commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8
>
>> I don't think that "style: " is a subject prefix that is used commonly
>> and it certainly should not belong in a commit subject. Mark can you
>> please people at least 10-12 hours to review changes before applying
>> them? This one is trivial except the commit subject does not match
>> previous changes done to this file and it should have been fixed.
>
> Honestly for super trivial stuff like this I'm not sure it's a useful
> use of anyone's time to police this sort of stuff aggressively, it's
> after the prefixes that matter so I saw it easily and I'm having a hard
> time caring that it happens to be done as a prefix rather than saying
> style somewhere else in the subject.
That sounds fair, however it does look like people who submit trivial
patches are typically the ones that also tend not to follow prior
commits to the same file, and given the patch is trivial, enforcing a
consistent subject sort of offsets the less amount of time spent in
reviewing the patch.
>
> I will generally hold off for longer with these trivial patches on
> things where I expect to see some review but that's felt a bit patchy
> with the Broadcom drivers.
>
OK, we will try to be more reactive then, Kamal is in GMT-0500 and I am
GMT-0800 so it make take a bit of time for us to get to our review backlog.
Thanks!
--
Florian
next prev parent reply other threads:[~2021-01-11 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:26 [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison YANG LI
2021-01-11 16:29 ` Mark Brown
2021-01-11 16:41 ` Florian Fainelli
2021-01-11 17:05 ` Mark Brown
2021-01-11 17:21 ` Florian Fainelli [this message]
2021-01-11 17:29 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 9:54 YANG LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32b6ba61-91a8-ada3-1c8f-0e85d330f27e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).