From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers Date: Wed, 08 Jun 2016 14:26:51 +0200 Message-ID: <3685265.1KrVuCJFto@diego> References: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shawn Lin , Javier Martinez Canillas , Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Tomeu Vizoso Return-path: In-Reply-To: <1465371171-20810-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Am Mittwoch, 8. Juni 2016, 09:32:51 schrieb Tomeu Vizoso: > When using DMA, the transfer_one callback should return 1 because the > transfer hasn't finished yet. > > A previous commit changed the function to return 0 when the DMA channels > were correctly prepared. > > This manifested in Veyron boards with this message: > > [ 1.983605] cros-ec-spi spi0.0: EC failed to respond in time > > Signed-off-by: Tomeu Vizoso > Fixes: ea9849113343 ("spi: rockchip: check return value of > dmaengine_prep_slave_sg") > Cc: Shawn Lin > Cc: Heiko Stuebner > Cc: Javier Martinez Canillas looks like Mark already applied it, but nevertheless I was able to verify that this patch fixes the issue on my veyron jerry chromebook as well, so Tested-by: Heiko Stuebner -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html