From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: <broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <richard@nod.at>, <vigneshr@ti.com>,
<manivannan.sadhasivam@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <quic_srichara@quicinc.com>,
<quic_varada@quicinc.com>
Subject: Re: [PATCH v6 5/8] drivers: mtd: nand: use FIELD_PREP and GENMASK
Date: Wed, 22 May 2024 11:39:17 +0530 [thread overview]
Message-ID: <39ccbbbb-e6f5-89e3-e11c-a2338dcd5a30@quicinc.com> (raw)
In-Reply-To: <20240521145327.745f8b50@xps-13>
On 5/21/2024 6:23 PM, Miquel Raynal wrote:
> Hi,
>
> quic_mdalam@quicinc.com wrote on Tue, 21 May 2024 16:25:29 +0530:
>
>> Use the bitfield macro FIELD_PREP, and GENMASK to
>> do the shift and mask in one go. This makes the code
>> more readable.
>>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>> Change in [v6]
>>
>> * Added FIELD_PREP() and GENMASK() macro
>
> Maybe you want to include linux/bitfield.h now.
Ok
>
> Otherwise that's a great improvement.
>
> Thanks,
> Miquèl
next prev parent reply other threads:[~2024-05-22 6:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 10:55 [PATCH v6 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 4/8] drivers: mtd: nand: Add qpic_common API file Md Sadre Alam
2024-05-21 11:54 ` Krzysztof Kozlowski
2024-05-21 12:31 ` Md Sadre Alam
2024-05-21 12:51 ` Miquel Raynal
2024-05-22 6:08 ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 5/8] drivers: mtd: nand: use FIELD_PREP and GENMASK Md Sadre Alam
2024-05-21 12:53 ` Miquel Raynal
2024-05-22 6:09 ` Md Sadre Alam [this message]
2024-05-21 10:55 ` [PATCH v6 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-05-21 13:24 ` Miquel Raynal
2024-05-22 9:42 ` Md Sadre Alam
2024-05-22 12:33 ` Miquel Raynal
2024-05-23 3:34 ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 8/8] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ccbbbb-e6f5-89e3-e11c-a2338dcd5a30@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).