From: Sean Anderson <sean.anderson@linux.dev>
To: Mark Brown <broonie@kernel.org>
Cc: Michal Simek <michal.simek@amd.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jinjie Ruan <ruanjinjie@huawei.com>,
linux-arm-kernel@lists.infradead.org,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting
Date: Fri, 17 Jan 2025 11:17:35 -0500 [thread overview]
Message-ID: <3a38cc06-d052-420d-812e-7f3c0c6ef24c@linux.dev> (raw)
In-Reply-To: <5942e111-24ba-4d1b-bd4f-6b81dcc6c5dc@sirena.org.uk>
On 1/17/25 08:21, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 05:55:16PM -0500, Sean Anderson wrote:
>> This series adds support for resetting the QSPI controller if we have a
>> timeout. I find this greatly improves the stability of the device, which
>> would tend to break after any timeout.
>
> If you're hitting a timeout that tends to indicate there's already a
> serious stability problem...
This was mostly hit when I was hacking on the driver. But of course
there are probably still bugs lurking in this driver, so I think it is
good to handle the exceptional conditions in a more-robust way.
--Sean
next prev parent reply other threads:[~2025-01-17 16:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 22:55 [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting Sean Anderson
2025-01-16 22:55 ` [PATCH 1/5] dt-bindings: spi: zynqmp-qspi: Add reset Sean Anderson
2025-01-17 7:14 ` Michal Simek
2025-01-17 16:12 ` Sean Anderson
2025-01-23 22:45 ` Rob Herring
2025-01-23 22:57 ` Sean Anderson
2025-01-24 9:06 ` Michal Simek
2025-01-27 17:57 ` Rob Herring
2025-01-27 18:00 ` Sean Anderson
2025-01-16 22:55 ` [PATCH 2/5] spi: zynqmp-gqspi: Reset device in probe Sean Anderson
2025-01-16 22:55 ` [PATCH 3/5] spi: zynqmp-gqspi: Abort operations on timeout Sean Anderson
2025-01-17 7:15 ` Michal Simek
2025-01-16 22:55 ` [PATCH 4/5] spi: zynqmp-gqspi: Allow interrupting operations Sean Anderson
2025-01-17 8:41 ` Miquel Raynal
2025-01-17 16:12 ` Sean Anderson
2025-01-16 22:55 ` [PATCH 5/5] ARM64: xilinx: zynqmp: Add QSPI reset Sean Anderson
2025-01-17 13:21 ` [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting Mark Brown
2025-01-17 16:17 ` Sean Anderson [this message]
2025-01-17 16:48 ` Mark Brown
2025-01-17 16:50 ` Sean Anderson
2025-01-17 18:31 ` Miquel Raynal
2025-01-17 18:41 ` Mark Brown
2025-01-17 21:46 ` Sean Anderson
2025-01-20 13:49 ` Mark Brown
2025-01-21 16:51 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a38cc06-d052-420d-812e-7f3c0c6ef24c@linux.dev \
--to=sean.anderson@linux.dev \
--cc=amit.kumar-mahapatra@amd.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).