From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DBD1189BAF for ; Fri, 17 Jan 2025 16:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737130673; cv=none; b=HMzmwTF+vp2TjKA9Hd8fvdXBpjYZ5wiZS+rdgwSr4+Ec0BBwFf8fggk2XrBLe2CUW0X1mRJw6JvC5I3VsS0vNct3Jg3ZZM4Myt48kFFRTUYKisHG26BRIfe4qI0JMTt+zXt0vu8eLp7abq63fFGXLx63U06ckd+w/3egIQmru28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737130673; c=relaxed/simple; bh=2kn+h0Eyzx+YhueUsL2LuHHyc6KauMFm0Xc4mQ+/WlI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kxeOIvEe9I7e2qD4nGc6MIRMoaBkqkvZPuuUToC5bqa6KPtIZfxzv/K+vXFbYCgEIPi9O/Hts3H4lrkGClk70em9HjAB/O1sivxhRh06fRt4Q5IX/g1qNc5ooIaJZ9pIS/MYnEVAKjHf4aCl/bwwYpVwdSRnFeuxNIqeDcbxclU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EMwl132N; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EMwl132N" Message-ID: <3a38cc06-d052-420d-812e-7f3c0c6ef24c@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737130660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrxAphLxQ/2ui++fGGP+v+/yKexgQPbirksMsmnTX34=; b=EMwl132N2tZ7JKWLmj/7pzYNXMraFS2HCnJJ0j7NuAWbCV/MZAmht2TcLqluGAqhULmFR7 Igh68JdacUDY5hq1FpVca9gRoiIXLSf5NJGyeJDp25M0a+Pf8yAoDg4KKHz74g0hkXA00l 8fRjbEtELyHVkUOujycBR4SrdV6mfSI= Date: Fri, 17 Jan 2025 11:17:35 -0500 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting To: Mark Brown Cc: Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Jinjie Ruan , linux-arm-kernel@lists.infradead.org, Amit Kumar Mahapatra , Miquel Raynal , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20250116225521.2688224-1-sean.anderson@linux.dev> <5942e111-24ba-4d1b-bd4f-6b81dcc6c5dc@sirena.org.uk> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <5942e111-24ba-4d1b-bd4f-6b81dcc6c5dc@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/17/25 08:21, Mark Brown wrote: > On Thu, Jan 16, 2025 at 05:55:16PM -0500, Sean Anderson wrote: >> This series adds support for resetting the QSPI controller if we have a >> timeout. I find this greatly improves the stability of the device, which >> would tend to break after any timeout. > > If you're hitting a timeout that tends to indicate there's already a > serious stability problem... This was mostly hit when I was hacking on the driver. But of course there are probably still bugs lurking in this driver, so I think it is good to handle the exceptional conditions in a more-robust way. --Sean