From: William Qiu <william.qiu@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<devicetree@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Date: Wed, 5 Jul 2023 14:20:14 +0800 [thread overview]
Message-ID: <3cbff4f7-b113-7f37-83d7-c147260343b5@starfivetech.com> (raw)
In-Reply-To: <afcf67e3-a017-b747-a0cf-284a87a8d24a@linaro.org>
On 2023/7/5 14:00, Krzysztof Kozlowski wrote:
> On 05/07/2023 05:37, William Qiu wrote:
>>>> ---
>>>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
>>>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> index 91e540a92faf..42bb34c39971 100644
>>>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> @@ -11,6 +11,7 @@ maintainers:
>>>>
>>>> allOf:
>>>> - $ref: spi-controller.yaml#
>>>> + - $ref: /schemas/arm/primecell.yaml#
>>>
>>> This looks unrelated, so keep it as separate commit with its own rationale.
>>>
>> Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in
>> one commit, so do I need to put them in two commit?
>
> You need to provide rationale why this is needed. I would assume this is
> needed for every primecell, not only JH7110, right?
>
>
All right, I'll keep it as separate commit.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-07-05 6:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 9:21 [RESEND v1 0/2] Add SPI module for StarFive JH7110 SoC William Qiu
2023-07-04 9:21 ` [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names William Qiu
2023-07-04 9:38 ` Krzysztof Kozlowski
2023-07-05 3:37 ` William Qiu
2023-07-05 6:00 ` Krzysztof Kozlowski
2023-07-05 6:20 ` William Qiu [this message]
2023-07-04 9:22 ` [RESEND v1 2/2] riscv: dts: starfive: Add spi node for JH7110 SoC William Qiu
2023-07-04 9:39 ` Krzysztof Kozlowski
2023-07-04 12:26 ` Mark Brown
2023-07-04 12:27 ` Krzysztof Kozlowski
2023-07-04 13:16 ` Mark Brown
2023-07-04 13:21 ` Krzysztof Kozlowski
2023-07-04 14:13 ` Mark Brown
2023-07-04 16:41 ` Conor Dooley
2023-07-05 3:40 ` William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cbff4f7-b113-7f37-83d7-c147260343b5@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).