From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96035EB64DD for ; Wed, 5 Jul 2023 06:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbjGEGUc (ORCPT ); Wed, 5 Jul 2023 02:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjGEGUb (ORCPT ); Wed, 5 Jul 2023 02:20:31 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 062B410CF; Tue, 4 Jul 2023 23:20:28 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id DB84424E257; Wed, 5 Jul 2023 14:20:15 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 14:20:15 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 14:20:14 +0800 Message-ID: <3cbff4f7-b113-7f37-83d7-c147260343b5@starfivetech.com> Date: Wed, 5 Jul 2023 14:20:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Linus Walleij References: <20230704092200.85401-1-william.qiu@starfivetech.com> <20230704092200.85401-2-william.qiu@starfivetech.com> <1b65e8d1-d5e1-0d6b-1248-d9683be44db8@linaro.org> From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 2023/7/5 14:00, Krzysztof Kozlowski wrote: > On 05/07/2023 05:37, William Qiu wrote: >>>> --- >>>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- >>>> 1 file changed, 8 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> index 91e540a92faf..42bb34c39971 100644 >>>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> @@ -11,6 +11,7 @@ maintainers: >>>> >>>> allOf: >>>> - $ref: spi-controller.yaml# >>>> + - $ref: /schemas/arm/primecell.yaml# >>> >>> This looks unrelated, so keep it as separate commit with its own rationale. >>> >> Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in >> one commit, so do I need to put them in two commit? > > You need to provide rationale why this is needed. I would assume this is > needed for every primecell, not only JH7110, right? > > All right, I'll keep it as separate commit. > > Best regards, > Krzysztof >