From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8E427A92E for ; Tue, 1 Jul 2025 15:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383034; cv=none; b=HkT9bTpt9paBJOUdCRAmkKPLLkSOaHKBiRuDQHFl+gILUF0dOrWNvcxgAQ94e91J0OJOeQQcFdbkSj0Sw7m41+8zXfC+apIpGDcs3xJT7sfPivmrcmFhKua+GuZBRKYCT4PgwjmanymMSWAlKERQ+2Y32f+xIHp5ChTSyR1BvAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383034; c=relaxed/simple; bh=UzPkDkcjv+i8GzG9JMJlLQc03B+nxyKMyUaYhYyrDlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IV5c0vSswU6LWfz7/NCXm+IvT3D9104U5sBU0kAJUC6v/SE9OyT5ZQCVf7V7qqbPCzMKti0h4RTo01KYb1utoYputGASF2vufW8UzGYzwpTDfm4P6dLT/I6IoXTH2bUz8NpF1XioMV6wfE50JYFCdIOXIh8zgBQTRVqboAxVHBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oEeNjyIh; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oEeNjyIh" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-2e95f0b6cb7so1816716fac.3 for ; Tue, 01 Jul 2025 08:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751383031; x=1751987831; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=oEeNjyIha5Q0rMOVv/dOBESLFIl3tCVNdulhcpPFl6jouUxmlrCJsW4yzUIrbKrYUW 7InVd+Ism4BHRYELuXHGbh3RU4xGq8lvHHjKC3chqmQWGZbTVMjCZ4Jwk3MH/Sst+g1h 5duqFCekryLkPDYTY5WSkarw0K9+yMd/gMQqD0JxGhxSgIn4SjIdQZPawhxn81PZcGvT BvA7EMi7B3hX5WC5rkrDNHt1hU7ehTYTEcd4ynG9Rv6VW14ivOwRcofosdFOxuXBc3V+ T6arT9yhVGJc9f20+Vzpd70yoNT8AVKxthQdQ/ghdFIjNXL1VdDJpK/n+QtYqkzK4vPC +AfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751383031; x=1751987831; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=SjOkZMBawJg2C34ajqea/8Y3BbbVwm+rWX9DJhqNeol2fW5d6k0Top41wkVtCAPHmV i10Z3U55tlB1FeI49+d4ASy2hDrpcg1EKqIR7ejibblXBfmf6RUIUkeLo2MmqHdBiRHG mdmG7fOlzT5rIaFEmv6nsUdWYsogTkOzumgDDAwLf2Mi5w6BgKeL57ADCAXYAqnm3efF o5PjZNc0g2iQf1EkDD93Rj7I1XN99ASOE2RGkUa83WjfSsD8U7w2YI3qCTzzUsHpXAfH dk5Y8LJYkXhINB88Xwi3f41LZIZPOXl4MXglAQfMx/VcBVWYGLK3SNd6yKLLhpYtwkXw Vh8w== X-Forwarded-Encrypted: i=1; AJvYcCW6gNJe6l48EUS4xxkP0USQ0SVq1pY7enIlHng3010unbfadkFibSQSqcynaefO5U0Rv23SLwVx+wM=@vger.kernel.org X-Gm-Message-State: AOJu0YyRuIiO1JMSBX5En/bvOUzcJTW4sZuYSeg1guS4+s+b5zKdrPmc As7tTjJ8wnl6ldYDnbILT8TvumiSLQbqitfYj+yg2AcjsfhuRXQHL0jPT3Z3KfFn5M4= X-Gm-Gg: ASbGncsCxtY6xsjOu64Dv+SG3Xb7hwljlquewNCBHIrmichu4aq/1PTnm0ebZjsu2k4 R8QxGgL9o5EG/PmsRzeLy9fmQI7uKgz2wn073GSQvZc5pXP1zPs2m9sUaWvSNSLF13oft+2Su99 amjlzDLxvHIfapY3feOPT3CxjnANAR3kNoW3kZCqU839lfnaXP7WcnjnrMjEH2NpmKjaG7ah7oH 13WL8vteaCUkoC9YOOrd3xKLuyj2lsw0RTmdOPBfLEvsnnXmqSzwdIsneV0nEvJ3/AIfCnReZC0 c0ybsZD3HXbxrXGcwoW757AuPxgASpgd/yR8VNE50b5+ePVMUfqGwCXRNQL0nkldYhjNH4uc4FI DZYHFbHUIKn+P+qzkesZnFIPnBbUXcJI/FPmA0YE= X-Google-Smtp-Source: AGHT+IGFKFZEsYZ4erbtAtqvl8tEHdHdyZFtcG8OKzWXPDqsQnJB5BtiKcEBEjaczDbwqY+Qnse9tA== X-Received: by 2002:a05:6871:82a:b0:2c7:6f57:3645 with SMTP id 586e51a60fabf-2efed67879emr12142176fac.18.1751383010329; Tue, 01 Jul 2025 08:16:50 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5? ([2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd50fb14esm3319606fac.42.2025.07.01.08.16.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 08:16:49 -0700 (PDT) Message-ID: <3df2c424-297e-4538-b350-5c465b22fa39@baylibre.com> Date: Tue, 1 Jul 2025 10:16:47 -0500 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset() To: Waqar Hameed , Vignesh Raghavendra , Julien Panis , William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , Peter Rosin , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , Dmitry Torokhov , Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sebastian Reichel , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Souradeep Chowdhury , Greg Kroah-Hartman , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: kernel@axis.com, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, imx@lists.linux.dev, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/1/25 10:03 AM, Waqar Hameed wrote: > When `devm_add_action_or_reset()` fails, it is due to a failed memory > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > anything when error is `-ENOMEM`. Therefore, remove the useless call to > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > return the value instead. > > Signed-off-by: Waqar Hameed > --- I can't speak for all subsystems, but this would probably be acceptable in the iio subsystem. However, I don't think anyone is going to accept a patch that touches all of these files at the same time across subsystems. So I would suggest to split this up into one patch per driver and create one series per subsystem. This way, each subsystem isn't bothered by unrelated patches that they don't particularly need to care about. And note that some subsystems like net have additional expectations, e.g for the patch subject so that it gets picked up by automated tools, so be sure to check the docs for this.