From: "weiyongjun (A)" <weiyongjun1@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>
Subject: Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver
Date: Wed, 31 Aug 2022 12:39:37 +0800 [thread overview]
Message-ID: <3ec5a47c-ec72-328c-cc69-bb84190f3c1e@huawei.com> (raw)
In-Reply-To: <Yw5g8zalllhRxd9Z@sirena.org.uk>
On 2022/8/31 3:11, Mark Brown wrote:
> On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:
>
>> @@ -0,0 +1,221 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * SPI controller Testing Driver
>> + *
>> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
>> + */
>
> Please make the entire comment a C++ one so things look more
> intentional.
>
>> + master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
>> + if (!master) {
>> + pr_err("failed to alloc spi master\n");
>> + return -ENOMEM;
>> + }
>
> Please use the new _controller() API, we're trying to remove the
> use of outdated terminology.
>
Will fix them in next version.
Thanks,
Wei Yongjun
next prev parent reply other threads:[~2022-08-31 4:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 14:43 [PATCH -next 0/4] spi: Introduce BPF based SPI mockup controller Wei Yongjun
2022-08-26 14:43 ` [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver Wei Yongjun
2022-08-30 19:11 ` Mark Brown
2022-08-31 4:39 ` weiyongjun (A) [this message]
2022-08-26 14:43 ` [PATCH -next 2/4] spi: mockup: Add writeable tracepoint for spi transfer Wei Yongjun
2022-08-30 18:14 ` Mark Brown
2022-08-31 4:43 ` weiyongjun (A)
2022-08-26 14:43 ` [PATCH -next 3/4] spi: mockup: Add runtime device tree overlay interface Wei Yongjun
2022-08-29 21:29 ` Frank Rowand
2022-08-30 3:05 ` weiyongjun (A)
2022-08-30 10:27 ` Mark Brown
2022-08-30 19:24 ` Frank Rowand
2022-08-31 4:44 ` weiyongjun (A)
2022-08-26 14:43 ` [PATCH -next 4/4] spi: mockup: Add documentation Wei Yongjun
2022-08-30 18:21 ` Mark Brown
2022-08-30 19:08 ` [PATCH -next 0/4] spi: Introduce BPF based SPI mockup controller Mark Brown
2022-09-01 10:38 ` Mark Brown
2022-09-01 12:23 ` weiyongjun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ec5a47c-ec72-328c-cc69-bb84190f3c1e@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).