From: William Qiu <william.qiu@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<devicetree@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: spi: add reference file to YAML
Date: Fri, 14 Jul 2023 15:18:20 +0800 [thread overview]
Message-ID: <43ee3d3f-9ac9-f77b-dc4e-c44705f6efb3@starfivetech.com> (raw)
In-Reply-To: <3365c703-5e5c-de7e-3ce3-047c9ac560ee@linaro.org>
On 2023/7/13 18:12, Krzysztof Kozlowski wrote:
> On 13/07/2023 11:00, William Qiu wrote:
>> Add primecell.yaml as a refereence file to YAML.
>
> This we see from the diff, but why you are doing it? Please provide
> rationale and answer to "why" in your commits.
>
> Also typo: reference.
>
>>
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>> ---
>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> index 91e540a92faf..5e5a704a766e 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> @@ -11,6 +11,7 @@ maintainers:
>>
>> allOf:
>> - $ref: spi-controller.yaml#
>> + - $ref: /schemas/arm/primecell.yaml#
>>
>> # We need a select here so we don't match all nodes with 'arm,primecell'
>> select:
>
> Best regards,
> Krzysztof
>
I will explain it in next version.
Best regards,
William
next prev parent reply other threads:[~2023-07-14 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:00 [PATCH v2 0/3] Add SPI module for StarFive JH7110 SoC William Qiu
2023-07-13 9:00 ` [PATCH v2 1/3] dt-bindings: spi: add reference file to YAML William Qiu
2023-07-13 10:12 ` Krzysztof Kozlowski
2023-07-14 7:18 ` William Qiu [this message]
2023-07-13 9:00 ` [PATCH v2 2/3] dt-bindings: spi: constrain minItems of clocks and clock-names William Qiu
2023-07-13 10:13 ` Krzysztof Kozlowski
2023-07-13 12:28 ` Mark Brown
2023-07-13 12:39 ` Krzysztof Kozlowski
2023-07-13 13:48 ` Mark Brown
2023-07-13 14:57 ` Rob Herring
2023-07-14 7:14 ` William Qiu
2023-07-14 11:52 ` Mark Brown
2023-07-18 6:06 ` William Qiu
2023-07-18 14:07 ` Mark Brown
2023-07-13 9:00 ` [PATCH v2 3/3] riscv: dts: starfive: Add spi node for JH7110 SoC William Qiu
2023-07-24 18:28 ` (subset) [PATCH v2 0/3] Add SPI module for StarFive " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ee3d3f-9ac9-f77b-dc4e-c44705f6efb3@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).