From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 557EDC433ED for ; Sat, 8 May 2021 01:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 293F661464 for ; Sat, 8 May 2021 01:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbhEHBX7 (ORCPT ); Fri, 7 May 2021 21:23:59 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:37589 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhEHBX7 (ORCPT ); Fri, 7 May 2021 21:23:59 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UY66k6w_1620436976; Received: from B-X3VXMD6M-2058.local(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0UY66k6w_1620436976) by smtp.aliyun-inc.com(127.0.0.1); Sat, 08 May 2021 09:22:57 +0800 From: "xhao@linux.alibaba.com" Reply-To: xhao@linux.alibaba.com Subject: Re: [PATCH v1] spi: fix client driver can't register success when use GPIO as CS To: Linus Walleij , Andy Shevchenko , Sven Van Asbroeck Cc: "andriy.shevchenko@linux.intel.com" , "broonie@kernel.org" , "linux-spi@vger.kernel.org" References: <83ab9b6c-8fb2-b053-ecb3-04230ca34e48@linux.alibaba.com> <6bd8f178-51a2-3f45-8a16-80fdd4a3ed8e@linux.alibaba.com> Message-ID: <489967db-128c-a52a-e36b-15d116173bb2@linux.alibaba.com> Date: Sat, 8 May 2021 09:22:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org 在 2021/5/8 上午5:33, Linus Walleij 写道: > On Fri, May 7, 2021 at 9:11 AM Andy Shevchenko > wrote: > >> It can’t be done due to differences of the expectations from them. >> Your patch breaks OF as far as I understand. Linus? > It looks to me like it would break OF. > > commit 766c6b63aa044e84b045803b40b14754d69a2a1d > "spi: fix client driver breakages when using GPIO descriptors" > passes enable1 to gpiod_set_value_cansleep() expecting > gpiolib to handle polarity. > > If this should be changed, Sven van Asbroeck really needs > to look at it first. > > But I think Andy's approach is the best. Ok, agree, i check the relative patches, They do respond to different situations， Andy，When do you send out your patch to fix this problem？ > > Yours, > Linus Walleij -- Best Regards! Xin Hao