From: Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Documentation/spi/* compile warning fix
Date: Wed, 19 May 2010 15:25:59 -0400 [thread overview]
Message-ID: <4BF43B47.5050906@redhat.com> (raw)
In-Reply-To: <20100519175712.10378.62717.sendpatchset-lwyPSKVeczd+7Tl7ptjsKdvLeJWuRmrY@public.gmane.org>
Sorry everyone ... I left off [PATCH]: ... will resend shortly.
(And then I top-posted too...)
P.
On 05/19/2010 02:01 PM, Prarit Bhargava wrote:
> Fix this warning:
>
> Documentation/spi/spidev_fdx.c: In function `do_msg':
> Documentation/spi/spidev_fdx.c:61: warning: cast from pointer to integer of different size
> Documentation/spi/spidev_fdx.c:64: warning: cast from pointer to integer of different size
>
> buf should be unsigned long to match native arch on 32-bit x86 compile.
>
> Signed-off-by: Prarit Bhargava<prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/Documentation/spi/spidev_fdx.c b/Documentation/spi/spidev_fdx.c
> index fc354f7..36ec077 100644
> --- a/Documentation/spi/spidev_fdx.c
> +++ b/Documentation/spi/spidev_fdx.c
> @@ -58,10 +58,10 @@ static void do_msg(int fd, int len)
> len = sizeof buf;
>
> buf[0] = 0xaa;
> - xfer[0].tx_buf = (__u64) buf;
> + xfer[0].tx_buf = (unsigned long)buf;
> xfer[0].len = 1;
>
> - xfer[1].rx_buf = (__u64) buf;
> + xfer[1].rx_buf = (unsigned long) buf;
> xfer[1].len = len;
>
> status = ioctl(fd, SPI_IOC_MESSAGE(2), xfer);
>
------------------------------------------------------------------------------
next prev parent reply other threads:[~2010-05-19 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 18:01 Documentation/spi/* compile warning fix Prarit Bhargava
[not found] ` <20100519175712.10378.62717.sendpatchset-lwyPSKVeczd+7Tl7ptjsKdvLeJWuRmrY@public.gmane.org>
2010-05-19 19:25 ` Prarit Bhargava [this message]
[not found] ` <4BF43B47.5050906-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-19 19:36 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF43B47.5050906@redhat.com \
--to=prarit-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).