From: Linus Walleij <linus.walleij@stericsson.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] spi/pl022: make sure the chip_info dev pointer is set
Date: Fri, 1 Oct 2010 12:37:57 +0200 [thread overview]
Message-ID: <4CA5BA05.3000605@stericsson.com> (raw)
In-Reply-To: <AANLkTimZXF-ntBSROV2pVN+Td1Bek7C5DtKZTQgXY=Wt@mail.gmail.com>
Grant Likely wrote:
>> } else {
>> + /* Users should not set this field */
>> + chip_info->dev = &spi->dev;
>> dev_dbg(&spi->dev,
>> "using user supplied controller_data settings\n");
>> }
>
> Nack. data passed to a driver via the controller_data must be
> immutable as far as the device driver is concerned.
I posted another patch removing it instead, that's obviously the
right thing to do...
Yours,
Linus Walleij
prev parent reply other threads:[~2010-10-01 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 9:40 [PATCH] spi/pl022: make sure the chip_info dev pointer is set Linus Walleij
2010-09-30 14:33 ` Grant Likely
2010-10-01 10:37 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA5BA05.3000605@stericsson.com \
--to=linus.walleij@stericsson.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).