Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.

[Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>]

On 10/08/10 21:12, David Brownell wrote:
> On Fri, 2010-10-08 at 12:29 -0600, Grant Likely wrote:
>> On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote:
> 
>>> Is it ever wrong to over specify elements of a transfer?
> 
> I wouldn't say that's even possible.
> 
>>> We have a driver that (for historical reasons) specifies
>>> that a particular transfer is 8 bit.
>>> 	.bits_per_word = 8,
>>>
>>> This causes issues with the atmel spi driver which sees that
>>> the value is specified and hence fails the transfer.
> 
> 
> Specifying 8 there means the same as specifying zero.
Cool,

I'll post a patch (probably Monday now) to at least ensure the
atmel driver lets transfers through if we aren't trying to change
bits_per_word.

Thanks for getting back to us.

Jonathan
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb