From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver. Date: Sat, 09 Oct 2010 11:24:27 +0100 Message-ID: <4CB042DB.6020500@cam.ac.uk> References: <1283786178-6466-1-git-send-email-jic23@cam.ac.uk> <4C94B4A6.2060001@cam.ac.uk> <4CA0C7AB.8060905@cam.ac.uk> <4CA344A5.80205@cam.ac.uk> <4CAEFEF4.4040506@cam.ac.uk> <20101008182943.GJ3863@angua.secretlab.ca> <1286568720.1723.4.camel@helium> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: drivers-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org, David Brownell , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nicolas Ferre , matthias , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Brownell Return-path: In-Reply-To: <1286568720.1723.4.camel@helium> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 10/08/10 21:12, David Brownell wrote: > On Fri, 2010-10-08 at 12:29 -0600, Grant Likely wrote: >> On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote: > >>> Is it ever wrong to over specify elements of a transfer? > > I wouldn't say that's even possible. > >>> We have a driver that (for historical reasons) specifies >>> that a particular transfer is 8 bit. >>> .bits_per_word = 8, >>> >>> This causes issues with the atmel spi driver which sees that >>> the value is specified and hence fails the transfer. > > > Specifying 8 there means the same as specifying zero. Cool, I'll post a patch (probably Monday now) to at least ensure the atmel driver lets transfers through if we aren't trying to change bits_per_word. Thanks for getting back to us. Jonathan > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb