Re: [PATCH v3 01/12] misc: add driver for sequencer serial port

[Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>]

On 10/21/2010 07:12 PM, Andrew Morton wrote:
>
> ...
>
>> +/* Register Access Helpers */
>> +static inline u32 ssp_read(struct ti_ssp *ssp, int reg)
>> +{
>> +	return __raw_readl(ssp->regs + reg);
>> +}
>> +
>> +static inline void ssp_write(struct ti_ssp *ssp, int reg, u32 val)
>> +{
>> +	__raw_writel(val, ssp->regs + reg);
>> +}
> 
> Why are the __raw functions used here?
> 

These registers are to be accessed native endian at all times, and
therefore the le32 conversion done otherwise is inappropriate.

Thanks for the feedback.  I will post an updated series with these changes.

Regards
Cyril.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev