From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Chemparathy Subject: Re: [PATCH v3 01/12] misc: add driver for sequencer serial port Date: Fri, 22 Oct 2010 15:03:38 -0400 Message-ID: <4CC1E00A.3010109@ti.com> References: <1287694873-12904-1-git-send-email-cyril@ti.com> <1287694873-12904-2-git-send-email-cyril@ti.com> <20101022152024.65e8f181@lxorguk.ukuu.org.uk> Reply-To: cyril@ti.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "davinci-linux-open-source@linux.davincidsp.com" , "dbrownell@users.sourceforge.net" , sameo@linux.intel.com, "broonie@opensource.wolfsonmicro.com" , "linux-kernel@vger.kernel.org" , "grant.likely@secretlab.ca" , "rpurdie@rpsys.net" , "spi-devel-general@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" , "lrg@slimlogic.co.uk" To: Alan Cox Return-path: In-Reply-To: <20101022152024.65e8f181@lxorguk.ukuu.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 10/22/2010 10:20 AM, Alan Cox wrote: > On Thu, 21 Oct 2010 17:01:02 -0400 > Cyril Chemparathy wrote: > >> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port >> device. It has a built-in programmable execution engine that can be programmed >> to operate as almost any serial bus (I2C, SPI, EasyScale, and others). >> >> This patch adds a driver for this controller device. The driver does not >> expose a user-land interface. Protocol drivers built on top of this layer are >> expected to remain in-kernel. > > I suspect the driver belongs with the mfd drivers not with drivers/misc ? > > otherwise it looks very nice. Unlike MFDs, this device doesn't have cells with differing functionality. Instead it has functionally identical ports that can operate in a variety of modes. That said, does this still fit in with other MFD drivers? If so, I don't see a problem with moving it there. Thanks Cyril.