From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: spi-devel-general <spi-devel-general@lists.sourceforge.net>,
linux-omap <linux-omap@vger.kernel.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition
Date: Wed, 10 Nov 2010 11:32:59 +0100 [thread overview]
Message-ID: <4CDA74DB.1060102@free-electrons.com> (raw)
When SPI wake up from OFF mode, CS is in the wrong state: force it to
the inactive state.
During the system life, I monitored the CS behavior using a
oscilloscope. I also activated debug in omap2_mcspi, so I saw when
driver disable the clocks and restore context when device is not used.
Each time the CS was in the correct state.
It was only when system was put suspend to ram with off-mode activated
that on resume the CS was in wrong state( ie activated).
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/spi/omap2_mcspi.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index 2a651e6..938f14c 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -1139,6 +1139,15 @@ static u8 __initdata spi4_txdma_id[] = {
};
#endif
+/* When SPI wake up, CS is in wrong state: force it to unactive state*/
+static void omap2_mcspi_resume(struct spi_device *spi)
+{
+ omap2_mcspi_enable_clocks( spi_master_get_devdata(spi->master));
+ /* We need to togle CS state for OMAP take this chang in account*/
+ omap2_mcspi_force_cs(spi, 1);
+ omap2_mcspi_force_cs(spi, 0);
+ omap2_mcspi_disable_clocks( spi_master_get_devdata(spi->master));
+}
static int __init omap2_mcspi_probe(struct platform_device *pdev)
{
struct spi_master *master;
@@ -1194,6 +1203,7 @@ static int __init omap2_mcspi_probe(struct
platform_device *pdev)
master->transfer = omap2_mcspi_transfer;
master->cleanup = omap2_mcspi_cleanup;
master->num_chipselect = num_chipselect;
+ master->resume = omap2_mcspi_resume;
dev_set_drvdata(&pdev->dev, master);
-- 1.7.0.4
next reply other threads:[~2010-11-10 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 10:32 Gregory CLEMENT [this message]
2010-11-10 15:57 ` [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition Grant Likely
2010-11-10 16:41 ` Gregory CLEMENT
2010-11-10 17:07 ` Grant Likely
2010-11-11 9:34 ` Hemanth V
2010-11-11 11:57 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDA74DB.1060102@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).