Re: [PATCH v5 08/12] gpio: add ti-ssp gpio driver

[Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>]

On 11/15/2010 05:38 PM, Ryan Mallon wrote:
> On 11/16/2010 08:12 AM, Cyril Chemparathy wrote:
>> TI's SSP controller pins can be directly read and written to behave like a
>> GPIO.  This patch adds a GPIO driver that exposes such functionality.
>>
>> Signed-off-by: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
>> ---
[...]
>> +	spin_lock_init(&gpio->lock);
>> +	platform_set_drvdata(pdev, gpio);
>> +
>> +	gpio->chip.base  = pdata->start;
>> +	gpio->chip.ngpio = 4;
> 
> Is this always four or can the SSP peripheral be configured to have
> varying numbers of gpios. Maybe the number of gpios should be passed via
> platform data?
> 

This can only be 4 (hw defined per-port limit).

I have changed as per your other comments, and will post an update.

Thanks
Cyril.

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev