From: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
To: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org"
<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org"
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
"grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org"
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org"
<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
"alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org"
<alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org"
<lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>
Subject: Re: [PATCH v6 05/12] davinci: add spi devices on tnetv107x evm
Date: Fri, 19 Nov 2010 12:11:57 -0500 [thread overview]
Message-ID: <4CE6AFDD.50806@ti.com> (raw)
In-Reply-To: <4CE6A516.402-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
On 11/19/2010 11:25 AM, Sergei Shtylyov wrote:
[...]
>> + ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel");
>
> Why not just:
>
> int ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel");
>
> Also, and empty line after declaration wouldn't hurt.
>
[...]
>> + return gpio_set_value(gpio, cs ? 1 : 0);
>
> Why not do it right with gpio_direction_output() call?
Sure. I might as well change to use gpio_request_one() while I'm at it.
If I get enough comments to warrant another revision of this series, I
will put in this change at the time. Otherwise, I'd rather roll this in
with other patches on my pending list. Is that ok?
Thanks for taking a look, Sergei.
Regards
- Cyril.
next prev parent reply other threads:[~2010-11-19 17:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 15:55 [PATCH v6 00/12] tnetv107x ssp drivers Cyril Chemparathy
[not found] ` <1290182156-20104-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 15:55 ` [PATCH v6 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
[not found] ` <1290182156-20104-6-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 16:25 ` Sergei Shtylyov
[not found] ` <4CE6A516.402-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-11-19 17:11 ` Cyril Chemparathy [this message]
2010-11-19 15:55 ` [PATCH v6 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
[not found] ` <1290182156-20104-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-21 20:02 ` Ryan Mallon
[not found] ` <4CE97AE5.3040801-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2010-11-21 21:31 ` Grant Likely
2010-11-22 11:20 ` Mark Brown
2010-11-22 19:35 ` Ryan Mallon
2010-11-19 15:55 ` [PATCH v6 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
[not found] ` <1290182156-20104-12-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 16:44 ` Sergei Shtylyov
[not found] ` <4CE6A950.8040704-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-11-19 17:04 ` Cyril Chemparathy
[not found] ` <4CE6AE19.6090600-l0cyMroinI0@public.gmane.org>
2010-11-19 17:11 ` Sergei Shtylyov
2010-11-19 15:55 ` [PATCH v6 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE6AFDD.50806@ti.com \
--to=cyril-l0cymroini0@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).