From: Alexis RODET <alexis.rodet-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h
Date: Mon, 22 Nov 2010 15:15:12 +0100 [thread overview]
Message-ID: <4CEA7AF0.6000804@bvs-tech.com> (raw)
In-Reply-To: <1290434369.2529.38.camel@helium>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
Hi David,
Le 22/11/2010 14:59, David Brownell a écrit :
> On Mon, 2010-11-22 at 10:58 +0100, Alexis RODET wrote:
>> Hello,
>>
>> there is a problem with the double
>> definition of 'struct flash_platform_data' that are incompatible:
>>
>> in arch/arm/include/asm/mach/flash.h:
>> in include/linux/spi/flash.h:
>> Both headers are included in a number of machines or driver.
> And this patch doesn't touch machine or driver code, so it's incomplete.
Look at the patch in previous mail attachment and you'll see it does.
39 files changed, 41 insertions(+), 41 deletions(-)
Sorry I didn't put it in message core because I already posted it on
linux-mtd-IAPFreCvJWM7uuMidbF8XZu6nac5fYnt@public.gmane.org
I don't know the good usage.
> ISTR the last time this issue was raised, a similar incomplete patch was
> proposed.
>
> How about a patch that does the full rename??
What do you mean ?
Renaming 'struct flash_platform_data' from
arch/arm/include/asm/mach/flash.h also ?
Or moving arch/arm/include/asm/mach/flash.h in common includes ?
Alexis
[-- Attachment #2: Type: text/plain, Size: 369 bytes --]
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
[-- Attachment #3: Type: text/plain, Size: 210 bytes --]
_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
next prev parent reply other threads:[~2010-11-22 14:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101117160514.GA5308@n2100.arm.linux.org.uk>
[not found] ` <4CE6B27D.2000909@bvs-tech.com>
[not found] ` <20101121044720.GA6088@tarshish>
2010-11-22 9:58 ` [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h Alexis RODET
2010-11-22 13:59 ` David Brownell
2010-11-22 14:15 ` Alexis RODET [this message]
[not found] ` <4CEA7AF0.6000804-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2010-11-22 21:52 ` David Brownell
[not found] ` <327178.68946.qm-g47maUHHHF/6X00i2u5GFvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-11-23 9:30 ` Alexis RODET
2010-11-23 9:36 ` Baruch Siach
[not found] ` <20101123093643.GC6156-X57xyCW21FZ5l4KbKkTfamZHpeb/A1Y/@public.gmane.org>
2010-11-23 9:41 ` Alexis RODET
2010-11-23 9:44 ` Baruch Siach
[not found] ` <20101123094414.GD6156-X57xyCW21FZ5l4KbKkTfamZHpeb/A1Y/@public.gmane.org>
2010-11-23 9:55 ` Alexis RODET
[not found] ` <4CEB8F7C.6070102-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-21 19:28 ` Grant Likely
2011-01-24 11:37 ` [PATCH 0/1] " Alexis RODET
2011-01-24 15:16 ` [PATCH 1/1] " Alexis RODET
[not found] ` <4D3D6472.8030505-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-24 15:16 ` Alexis RODET
2011-01-24 15:49 ` [PATCH 0/1] " Alexis RODET
[not found] ` <4D3D9FA6.3050900-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-24 17:52 ` Grant Likely
[not found] ` <AANLkTikDHbKt5q+o2LK89hHZ3EUeeYzmQVJj8jXgQ+pB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-25 9:23 ` Alexis RODET
2011-01-31 11:29 ` [PATCH 1/1] merging arch/arm/include/asm/mach/flash.h and include/linux/spi/flash.h into single header file include/linux/mtd/flash.h Alexis RODET
[not found] ` <4D3E9683.5090906-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-31 11:29 ` Alexis RODET
[not found] ` <1296473351-22771-1-git-send-email-alexis.rodet-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-07-10 7:38 ` Grant Likely
2011-01-25 9:40 ` [PATCH 0/1] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h Alexis RODET
[not found] ` <4D3E9AA1.4020308-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-26 14:35 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA7AF0.6000804@bvs-tech.com \
--to=alexis.rodet-zroamvwsw6hwk0htik3j/w@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).