From: Ryan Mallon <ryan@bluewatersys.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
dbrownell@users.sourceforge.net, sameo@linux.intel.com,
khilman@deeprootsystems.com, linus.ml.walleij@gmail.com,
Grant Likely <grant.likely@secretlab.ca>,
rpurdie@rpsys.net, alan@lxorguk.ukuu.org.uk,
Cyril Chemparathy <cyril@ti.com>,
spi-devel-general@lists.sourceforge.net,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH v6 08/12] gpio: add ti-ssp gpio driver
Date: Tue, 23 Nov 2010 08:35:58 +1300 [thread overview]
Message-ID: <4CEAC61E.40504@bluewatersys.com> (raw)
In-Reply-To: <20101122112038.GD16504@rakim.wolfsonmicro.main>
On 11/23/2010 12:20 AM, Mark Brown wrote:
> On Sun, Nov 21, 2010 at 02:31:38PM -0700, Grant Likely wrote:
>> On Sun, Nov 21, 2010 at 1:02 PM, Ryan Mallon <ryan@bluewatersys.com> wrote:
>
>>> Currently the code will allow you to install
>>> several peripherals at once, which will lead to odd behaviour at
>>> runtime. Maybe a better approach would be to have something like this in
>>> drivers/mfd/ti-ssp.c:
>
>> Only the ssp core itself is allowed to register the peripheral
>> devices, and so using the parent pointer is perfectly valid. I think
>> Cyril's approach is fine.
>
> This is very much a standard idiom for MFD children in Linux - if the
> children are entirely reliant on working through a parent-specific API
> anyway there's no issue with making the parent device be part of that
> API.
Yeah, I misunderstood how the registration worked. It is fine as is,
ignore my comments :-).
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-11-22 19:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 15:55 [PATCH v6 00/12] tnetv107x ssp drivers Cyril Chemparathy
[not found] ` <1290182156-20104-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 15:55 ` [PATCH v6 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
[not found] ` <1290182156-20104-6-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 16:25 ` Sergei Shtylyov
[not found] ` <4CE6A516.402-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-11-19 17:11 ` Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
[not found] ` <1290182156-20104-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-21 20:02 ` Ryan Mallon
[not found] ` <4CE97AE5.3040801-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2010-11-21 21:31 ` Grant Likely
2010-11-22 11:20 ` Mark Brown
2010-11-22 19:35 ` Ryan Mallon [this message]
2010-11-19 15:55 ` [PATCH v6 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-11-19 15:55 ` [PATCH v6 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
[not found] ` <1290182156-20104-12-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-19 16:44 ` Sergei Shtylyov
[not found] ` <4CE6A950.8040704-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-11-19 17:04 ` Cyril Chemparathy
[not found] ` <4CE6AE19.6090600-l0cyMroinI0@public.gmane.org>
2010-11-19 17:11 ` Sergei Shtylyov
2010-11-19 15:55 ` [PATCH v6 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEAC61E.40504@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cyril@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).