From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [sodaville] SPI support for CE4100, v2 Date: Thu, 09 Dec 2010 17:43:54 +0100 Message-ID: <4D01074A.2020106@linutronix.de> References: <1291312057-7933-1-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <1291312057-7933-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Sebastian Andrzej Siewior wrote: > The SPI core inside CE4100 is very much the same as in PXA25x. > I Cc the ARM folks because patch 4 reorganizes some files so that they > can be access from x86. Yes, CE4100 is a x86 SoC :) > The SPI device is behind a PCI bus. The PCI probe code simply creates a > platform device so we don't have much changes to the platform driver. > There is no clock framework on x86 and the peripherals don't support > changing their clocks or to enable/disable them. So I provided dummy > function which keep the driver happy. > > History: > v1: initial post > v2: - the patch touching subys_inticall() got removed. > - platform_driver_probe() is replaced with platform_driver_register() > - there are no files created in include/asm. > > The patch series has been created with the -M option so file moves can > be easily noticed. The whole series is also available at > git://git.linutronix.de/users/bigeasy/soda.git spi It's been week since I posted this and nobody commented on it. Is this patchset missing something or is it good to go? Sebastian ------------------------------------------------------------------------------