From: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
To: changgx <changgx@163.com>
Cc: "hunterzhu@baite-group.com" <hunterzhu@baite-group.com>,
spi-devel-general@lists.sourceforge.net,
linux-serial@vger.kernel.org
Subject: Re: Fw: about sc16is7x2 drivier
Date: Mon, 20 Dec 2010 10:09:32 +0100 [thread overview]
Message-ID: <4D0F1D4C.4010600@iis.fraunhofer.de> (raw)
In-Reply-To: <4D0F1B6A.0A69AA.31769@m50-133.163.com>
[-- Attachment #1: Type: text/plain, Size: 3950 bytes --]
Hello Kathy Chang,
thank you for your effort. Can you provide a patch for the sc16is7x2.c file?
Regards,
Manuel Stahl
On 20.12.2010 10:01, changgx wrote:
> hello,Manuel Stahl:
>
> Sc16is7x2 driver has been successfully debugged.
>
> In sc16is7x2.c,the control to the var .cs_change does not match with at91sam9260 driver.
>
> 1、
> In function sc16is7x2_startup(),the spi chip select maintains low level after the setence cmds = sc16is7x2_alloc_spi_cmds(8).
> It caused a error about next SPI operation.
>
> Improved method is to use 8 sc16is7x2_write_async() function to set sc16is7x2 reg.
>
> 2、
>
> In sc16is7x2_msg_add_fifo_tx() function, you need to take anti-cs_change variables.
>
>
> good luck!!!
>
>
> ======= 2010-12-14 11:52:00 您在来信中写道:=======
>
>> Hello again,
>>
>> The commands in sc16is7x2_spi_async are sent async (as the name says),
>> so the first time you execute sc16is7x2_read(ts->spi, UART_IER,ch) the
>> async part was not yet completed, the second time it was completed and
>> has set UART_IER to 0.
>>
>> Regards,
>> Manuel
>>
>> On 13.12.2010 06:43, changgx wrote:
>>> hello,manuel.stahl:
>>>
>>> excuse me!!
>>>
>>> I found the sc16is7x2.c driver provided by you on the internet the
>>> other day. And I explante it to my board.
>>>
>>> My develop environment is about :CPU for AT91SAM9260 and kennel for
>>> linux-2.6.27.
>>>
>>> But I found some questions in debugging.
>>>
>>> In the function of sc16is7x2_startup( ), i add the sentence to read
>>> register value after sc16is7x2_spi_async(ts->spi, cmds, 8) sentence
>>> and i find that the return value is always 0xff.
>>>
>>> for example:
>>>
>>> int uier1,uier2;
>>>
>>> uier1 = sc16is7x2_read(ts->spi, UART_IER,ch);
>>> SC16_PRINTK("+++++++++++++++++++++> s :d UART_IER = x
>>> \n",__func__,__LINE__,uier1);
>>> uier2 = sc16is7x2_read(ts->spi, UART_IER,ch);
>>> SC16_PRINTK("+++++++++++++++++++++> s :d UART_IER = x
>>> \n",__func__,__LINE__,uier2);
>>>
>>> the print result:
>>>
>>> +++++++++++++++++++++> sc16is7x2_startup : 512 UART_IER = ff
>>> +++++++++++++++++++++> sc16is7x2_startup : 515 UART_IER = 0
>>>
>>> The results is that the first time is 0xff, the secend is 0.
>>>
>>> And it is same to read other register.
>>>
>>> please give me some advice for this question.
>>>
>>> ps: thank you very much for your open souce and look forward to your
>>> email.
>>>
>>> thanks!
>>>
>>> kathy chang
>>>
>>> 2010-12-13
>>>
>>> ------------------------------------------------
>>>
>>> Email:changgx@163.com<mailto:changgx@163.com>
>>>
>>> ------------------------------------------------
>>>
>>>
>>>
>>> = = = = = = = = = = = = = = = = = = = =
>>> 致
>>> 礼!
>>> changgx
>>> changgx@163.com<mailto:changgx@163.com>
>>> 2010-12-13
>>>
>>
>>
>> --
>> Manuel Stahl
>> Fraunhofer-Institut IIS
>> Leistungsoptimierte Systeme
>>
>> Nordostpark 93
>> D90411 Nürnberg
>> Telefon +49 (0)911/58061-6419
>> Fax +49 (0)911/58061-6398
>> E-Mail manuel.stahl@iis.fraunhofer.de
>>
>> http://www.iis.fraunhofer.de
>> http://www.smart-power.fraunhofer.de
>>
>>
>>
>> __________ Information from ESET Smart Security, version of virus signature database 5563 (20101026) __________
>>
>> The message was checked by ESET Smart Security.
>>
>> http://www.eset.com
>
> = = = = = = = = = = = = = = = = = = = =
>
>
> 致
> 礼!
>
>
> changgx
> changgx@163.com
> 2010-12-20
>
>
>
>
--
Manuel Stahl
Fraunhofer-Institut IIS
Leistungsoptimierte Systeme
Nordostpark 93
D90411 Nürnberg
Telefon +49 (0)911/58061-6419
Fax +49 (0)911/58061-6398
E-Mail manuel.stahl@iis.fraunhofer.de
http://www.iis.fraunhofer.de
http://www.smart-power.fraunhofer.de
[-- Attachment #2: manuel_stahl.vcf --]
[-- Type: text/x-vcard, Size: 170 bytes --]
begin:vcard
fn:Manuel Stahl
n:Stahl;Manuel
email;internet:manuel.stahl@iis.fraunhofer.de
tel;work:+49 911 58061-6419
x-mozilla-html:FALSE
version:2.1
end:vcard
next parent reply other threads:[~2010-12-20 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D0F1B6A.0A69AA.31769@m50-133.163.com>
2010-12-20 9:09 ` Manuel Stahl [this message]
2010-12-20 10:03 ` about sc16is7x2 drivier Manuel Stahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0F1D4C.4010600@iis.fraunhofer.de \
--to=manuel.stahl@iis.fraunhofer.de \
--cc=changgx@163.com \
--cc=hunterzhu@baite-group.com \
--cc=linux-serial@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).