From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 3/7] spi/pl022: skip default configuration before suspending Date: Tue, 22 Nov 2011 13:57:11 +0530 Message-ID: <4ECB5CDF.1050401@st.com> References: <1321950293-4749-1-git-send-email-linus.walleij@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Linus Walleij , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Virupax SADASHIVPETIMATH To: Linus WALLEIJ Return-path: In-Reply-To: <1321950293-4749-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 11/22/2011 1:54 PM, Linus WALLEIJ wrote: > From: Virupax Sadashivpetimath > > The loading of the default configuration before suspending has > been in the driver since its inception, but it is not really > needed. Especially so since we take to all the trouble of > enabling and disabling power and clock just to do this. Let's > scrap this now. > > Signed-off-by: Virupax Sadashivpetimath > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Use local dev pointer instead of copy/paste bug &adev->dev > --- > drivers/spi/spi-pl022.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c > index 0d0b165..b4038f9 100644 > --- a/drivers/spi/spi-pl022.c > +++ b/drivers/spi/spi-pl022.c > @@ -2310,11 +2310,6 @@ static int pl022_suspend(struct device *dev) > return status; > } > > - amba_vcore_enable(pl022->adev); > - amba_pclk_enable(pl022->adev); > - load_ssp_default_config(pl022); > - amba_pclk_disable(pl022->adev); > - amba_vcore_disable(pl022->adev); > dev_dbg(dev, "suspended\n"); > return 0; > } Reviewed-by: Viresh Kumar -- viresh ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d