From: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
To: Linus WALLEIJ <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Christopher BLAIR
<chris.blair-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread
Date: Tue, 22 Nov 2011 13:58:30 +0530 [thread overview]
Message-ID: <4ECB5D2E.1000906@st.com> (raw)
In-Reply-To: <1321950301-4782-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
On 11/22/2011 1:55 PM, Linus WALLEIJ wrote:
> if (list_empty(&pl022->queue) || !pl022->running) {
> + if (pl022->busy) {
> + pm_runtime_put(&pl022->adev->dev);
> + }
We used to get warnings from checkpatch, for single line code inside {}.
Don't we get them anymore?
Reviewed-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
--
viresh
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
next prev parent reply other threads:[~2011-11-22 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 8:25 [PATCH 4/7] spi/pl022: move device disable to workqueue thread Linus Walleij
[not found] ` <1321950301-4782-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2011-11-22 8:28 ` Viresh Kumar [this message]
[not found] ` <4ECB5D2E.1000906-qxv4g6HH51o@public.gmane.org>
2011-11-22 9:28 ` Linus Walleij
2011-12-07 20:22 ` Wolfram Sang
[not found] ` <20111207202203.GA3744-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-12-07 22:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB5D2E.1000906@st.com \
--to=viresh.kumar-qxv4g6hh51o@public.gmane.org \
--cc=chris.blair-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).