From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread Date: Tue, 22 Nov 2011 13:58:30 +0530 Message-ID: <4ECB5D2E.1000906@st.com> References: <1321950301-4782-1-git-send-email-linus.walleij@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Linus Walleij , Christopher BLAIR , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" To: Linus WALLEIJ Return-path: In-Reply-To: <1321950301-4782-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: > if (list_empty(&pl022->queue) || !pl022->running) { > + if (pl022->busy) { > + pm_runtime_put(&pl022->adev->dev); > + } We used to get warnings from checkpatch, for single line code inside {}. Don't we get them anymore? Reviewed-by: Viresh Kumar -- viresh ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d