From: Sylwester Nawrocki <sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts
Date: Sat, 21 Jan 2012 17:42:30 +0100 [thread overview]
Message-ID: <4F1AEAF6.3000004@gmail.com> (raw)
In-Reply-To: <20120121152947.GD10751-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On 01/21/2012 04:29 PM, Mark Brown wrote:
> On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote:
>> On 01/21/2012 02:24 PM, Mark Brown wrote:
>
>>> - int ret;
>>> + int ret, irq;
>>> + char clk_name[16];
>
>> clk_name seems to be unused, otherwise looks good.
>
> That's git cherry-pick being too clever for me when I pulled this out of
> my -next branch for Grant. clk_name is used in -next by some updates
> which I guess Kukjin is carrying, I hadn't noticed they weren't in the
> SPI tree. I don't know if it's better to just leave things as they are
> for now given that it'll all come out in the merge window?
Indeed, the orphaned variable is already sitting in -next. I guess it
can be handled during merge.
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
next prev parent reply other threads:[~2012-01-21 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 13:23 [PATCH 0/3] spi/s3c64xx diagnostic and PM updates Mark Brown
2012-01-21 13:24 ` [PATCH 1/3] spi/s3c64xx: Log error interrupts Mark Brown
2012-01-21 13:24 ` [PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops Mark Brown
2012-01-21 13:24 ` [PATCH 3/3] spi/s3c64xx: Implement runtime PM support Mark Brown
2012-01-21 13:41 ` Bill Gatliff
2012-01-21 14:18 ` Mark Brown
2012-01-21 15:27 ` [PATCH 1/3] spi/s3c64xx: Log error interrupts Sylwester Nawrocki
[not found] ` <4F1AD954.9030303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-21 15:29 ` Mark Brown
[not found] ` <20120121152947.GD10751-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-21 16:42 ` Sylwester Nawrocki [this message]
[not found] ` <1327152265-10789-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-28 17:00 ` Shubhrajyoti Datta
2012-01-29 21:40 ` Mark Brown
2012-02-01 6:20 ` Shubhrajyoti Datta
2012-01-21 14:27 ` [PATCH 0/3] spi/s3c64xx diagnostic and PM updates Grant Likely
2012-01-21 15:13 ` Mark Brown
2012-01-30 15:37 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 21:01 [PATCH 1/3] spi/s3c64xx: Log error interrupts Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1AEAF6.3000004@gmail.com \
--to=sylvester.nawrocki-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).