From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA1E1B596 for ; Wed, 24 Jan 2024 09:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706088108; cv=none; b=nS/TTSTIuPXfc2g77MOVrC0qNlGYMrKe+bDrCopROoNxSLxGhKhTZs/R9dTOgHhvTsNILMoDyKH6q0tB6M4gxvCOujgI17mBlpIbgqMbNzKQQx1KTrp2J5+If56Uf+0jknCMePyUPqvJ+hNqesn5Y5C40g9M0nVsp+iMnWZO+mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706088108; c=relaxed/simple; bh=eF+zjiEZUQuKsPtg6bAJeNDrxHW3hVhj8Si24oj2+Z4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aHTCsGli42LwF+ZM/aMgP7EirryXPMiK+c56yeg7RSNJW8BEc33zBfZfT8c/sv/PwyAALyyzUCkuAyew9rGq9sIw1oPzhFR8BL2TOm6iNC2hw2b92pbuSKe6ujK5uKooAtgQROniSR0SXlrHlxEKIzugFmTHrGrTyLMX7MpIJSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uqGqtlSM; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uqGqtlSM" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-50ea9daac4cso5653973e87.3 for ; Wed, 24 Jan 2024 01:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706088105; x=1706692905; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IC++pEzL4ZnERNcYi29RUcf4swv7sgMAYOvkDj2rEI0=; b=uqGqtlSMa38hdsgpvsN2tMQiJ80+RdNx3Tmk/6FuI8BJw2K9hrFnim09ElK7tdplUz i8+klwrWgorbEuPAI2v0Hh1tyZ3EZ5U/JR6B70gu0hyM++U8I1TNiojF6oTWvS/MUX9o 4KKSfRm+6mlgLmMnb8eXdKoJbsbinj5cevwI0DcfSIVgK+DELDto8FEOeUpu2rW4pEwG vSLcwuxy5LTqymLeKgMcDm1+VBx5kUUN81Fike9LdfypAeZG1y/Z57jcNVutDd4tt9Cn wfvapFDUjSLusXfQMxLKo6Kb/yYti/XBnn5mj4zS6C5lQwrLO56AjkDPq6ij/yXJSxRG gXxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706088105; x=1706692905; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IC++pEzL4ZnERNcYi29RUcf4swv7sgMAYOvkDj2rEI0=; b=DZYno59oKAUYre1+8F6Um4c+OMqfJ4wMsL0Pyk41v1HAFKtbt0PgyjS45n+QrJ7mUT W4GzCTDsuhEPwpPSwUF0QW9mpHamGn4JrIbTOfD0gmWDNNJre0TUM00vdE1UDi5VtKit 8L1kjD3ZaPgEbXO3d9S9louUSYBNSe4bGkadDKubksR7M1XlIqC4qRALzgDz/DpdjGc1 mNK0gSHAH7QWazzkLjnC1butHXKcP1geAiFAK62L3d2Kf96EioUyhDQpdDxJCv74dOJQ lm36Bbx50UrNmAIGi42vUeKd4StnY/WmbfQh30uCgV1s2wWZ4tn30J8R1UZn0bwVIfUQ PXqA== X-Gm-Message-State: AOJu0Yw+tl2TsFiHHxRVgL/D6pLiwf0tkj3hHESBnfV+9SS3YVzRUW+v tiZh4vmlmunqEUzIEusgwabs8O/1rQwKrOHJL0VTSIjh3mYLvwpER+OlcEi8RNc= X-Google-Smtp-Source: AGHT+IEoYvX5ImUeYU+16v/15tdK/S4Fr5ldyMNN4WvuO6GvQxlrpO1w2+L1HPxfqJrOi6yJv0guLA== X-Received: by 2002:a05:6512:6d3:b0:50e:e0af:4efb with SMTP id u19-20020a05651206d300b0050ee0af4efbmr3997062lff.104.1706088104912; Wed, 24 Jan 2024 01:21:44 -0800 (PST) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id q20-20020a05600c46d400b0040e395cd20bsm48914383wmo.7.2024.01.24.01.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 01:21:44 -0800 (PST) Message-ID: <4b8bc0bf2f1fd87183276816522e92f7b0c3b1fd.camel@linaro.org> Subject: Re: [PATCH 08/21] spi: s3c64xx: move error check up to avoid rechecking From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Tudor Ambarus , broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, peter.griffin@linaro.org, semen.protsenko@linaro.org, kernel-team@android.com, willmcvicker@google.com Date: Wed, 24 Jan 2024 09:21:43 +0000 In-Reply-To: <20240123153421.715951-9-tudor.ambarus@linaro.org> References: <20240123153421.715951-1-tudor.ambarus@linaro.org> <20240123153421.715951-9-tudor.ambarus@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1-1 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Tudor, On Tue, 2024-01-23 at 15:34 +0000, Tudor Ambarus wrote: > @@ -538,13 +538,8 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_d= river_data *sdd, > =C2=A0 cpu_relax(); > =C2=A0 status =3D readl(regs + S3C64XX_SPI_STATUS); > =C2=A0 } > - > =C2=A0 } > =C2=A0 > - /* If timed out while checking rx/tx status return error */ > - if (!val) > - return -EIO; > - This change behaviour of this function. The loop just above adjusts val and= it is used to determine if there was a timeout or not: if (val && !xfer->rx_buf) { val =3D msecs_to_loops(10); status =3D readl(regs + S3C64XX_SPI_STATUS); while ((TX_FIFO_LVL(status, sdd) || !S3C64XX_SPI_ST_TX_DONE(status, sdd)) && --val) { cpu_relax(); status =3D readl(regs + S3C64XX_SPI_STATUS); } That doesn't work anymore now. Cheers, Andre'