From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B58CCC54EBE for ; Mon, 9 Jan 2023 08:56:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236964AbjAII4p (ORCPT ); Mon, 9 Jan 2023 03:56:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233522AbjAII4D (ORCPT ); Mon, 9 Jan 2023 03:56:03 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4071813F7C for ; Mon, 9 Jan 2023 00:48:32 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id ay40so5718842wmb.2 for ; Mon, 09 Jan 2023 00:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ro2kDxZz7EAGoP5oHQ+mMCthtYR+NfGs0EcWvR992/U=; b=a1OUTyWsfSJOzJkq+NwDuyY/u+r1EWBFBTPp+MSvMayYRSPvsimiqnzJ3htgctQ5Tr H42l6ypH6FWYVco1PA4qDAcL+pQfwJA28WXGboOgrdKtJEJK0WGxFkSIikTWyXPi4UVC Sh2xXV44YDtv6mvhmgaFUWamT+S9ustTKX9e6oKFdo4obgzrYKlA3O/yHWXJfACtZAz0 kPwO6GKzamgxGgvu0QSmbRkSMtfN7Fyqr5wE7ZSEUR306HqUN0YE2QfCuKTCl1Ky0P2G aIbI9LRDd9wptntPhaAN5+jP09rc3iU81rI6+V0VpwU0P7SQLbIj4qdZSpoAYE0TFp6R e0MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ro2kDxZz7EAGoP5oHQ+mMCthtYR+NfGs0EcWvR992/U=; b=4Yd5yZT0sjgWUN27RRdbq3To5MKxPsLfNlcK1DkXViEmyrJmLVjbANWvhsUXtrTb87 2LmNirMXP4NvPtEZcvghxW8Q3d2D1OVErUK0VnsfrtGMy9cUECx2cpajj9LETCK1dHxT bAylTLBti3tz8lGDzl6dlBF+Wqp2QoUzNx/tK9cCBx5laIst6/5xZh1fNhYWoPDzpUSJ r6cp2oRphjal4RDBMcYWQrPTcvIBP9PTGpLITQTR57I/9MYJkqKkq8ApdKVHwxQG2roG wetlyuy5UiANY8+iO1jCuXUj9vthyP8IYRM/RlpqiXbPGyRwv3/Gx0yKpWx+UTQOW3l/ QZCw== X-Gm-Message-State: AFqh2kpb1tD/4UZh7m0JYySQgOzyWeOSOMQnf4/qxNuryBARQqqa6yAH J/2P/glcuXci/GldiXPn313VcA== X-Google-Smtp-Source: AMrXdXumc1fDCo2pgBLphIGetaLBrbPrgwuQjhJdu0PBJh702GIp0qwkyrG9R0zgq9jtyJFIj454/Q== X-Received: by 2002:a05:600c:1ca3:b0:3d3:591a:bfda with SMTP id k35-20020a05600c1ca300b003d3591abfdamr48974353wms.27.1673254110851; Mon, 09 Jan 2023 00:48:30 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c350800b003d990372dd5sm16516337wmq.20.2023.01.09.00.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 00:48:30 -0800 (PST) Message-ID: <4e71bc38-27dc-4b81-49c9-c71c8e8f1cc4@linaro.org> Date: Mon, 9 Jan 2023 09:48:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 01/16] dt-bindings: spi: Convert bcm63xx-hsspi bindings to json-schema Content-Language: en-US To: William Zhang , Linux SPI List , Broadcom Kernel List Cc: anand.gore@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, f.fainelli@gmail.com, jonas.gorski@gmail.com, kursad.oney@broadcom.com, dregan@mail.com, Krzysztof Kozlowski , Mark Brown , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230106200809.330769-1-william.zhang@broadcom.com> <20230106200809.330769-2-william.zhang@broadcom.com> <0581eeed-f7d1-caf2-0dba-be14a01d7c05@linaro.org> <7828c353-e3f3-31d2-638d-3b11dc085a34@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: <7828c353-e3f3-31d2-638d-3b11dc085a34@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 09/01/2023 08:52, William Zhang wrote: > > > On 01/07/2023 07:32 AM, Krzysztof Kozlowski wrote: >> On 06/01/2023 21:07, William Zhang wrote: >>> This is the preparation for updates on the bcm63xx hsspi driver. Convert >>> the text based bindings to json-schema per new dts requirement. >>> >>> Signed-off-by: William Zhang >>> --- >>> >>> .../bindings/spi/brcm,bcm63xx-hsspi.yaml | 52 +++++++++++++++++++ >>> .../bindings/spi/spi-bcm63xx-hsspi.txt | 33 ------------ >>> 2 files changed, 52 insertions(+), 33 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >>> delete mode 100644 Documentation/devicetree/bindings/spi/spi-bcm63xx-hsspi.txt >>> >>> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >>> new file mode 100644 >>> index 000000000000..45f1417b1213 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >>> @@ -0,0 +1,52 @@ >>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/spi/brcm,bcm63xx-hsspi.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Broadcom BCM6328 High Speed SPI controller >>> + >>> +maintainers: >>> + - Jonas Gorski >>> + >> >> Missing reference to spi-controller. >> > This was word to word conversion from the text file. But I will update > with this required reference. > >>> +properties: >>> + compatible: >>> + const: brcm,bcm6328-hsspi >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + items: >>> + - description: spi master reference clock >>> + - description: spi master pll clock >>> + >>> + clock-names: >>> + items: >>> + - const: hsspi >>> + - const: pll >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - clocks >>> + - clock-names >>> + - interrupts >>> + >>> +unevaluatedProperties: false >> >> This is for cases when you have reference to other schema. >> > Will drop here. But will add back in patch 1 which produces the final > version of this file and need this property. When you add reference to spi-controller, keep it here. This was wrong when the reference was missing. Best regards, Krzysztof