From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55823F23DF for ; Wed, 26 Aug 2026 11:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787745299; cv=none; b=OSq/pQ1pV8KCAJTQgkm6UZAncfYIMF/y6kGwOktlSVBLByhTqCUZoB0UNJ5dKJMAs2F4NjWR+wbl03Y496JNOf6MM/DsWh8SE/V1hhkQSfu0k5cBgqsPdAqI2kvioRVWMyJGFk+Z5Ye/ZfiG1DPhMPgWsIicZC2qCe91T65LzcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787745299; c=relaxed/simple; bh=1bL8SHeY4H85ODVaWl9myp8bt68czbdVcvClUWMwZgw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V9J89YLqAP862JAqiTuLWKranUaWFWpBJLw8nXx13/IRgcdlHsNvfIpTusR8VOUmUvvi1zWsjL8twClQRyOVx4bhV/tzW8J3pFkYo4UULw8AnJ6cq8w/jWkjhB8xk95d2ri6UZldBYNIjxz9nfYgGOshcV9X+pSuVHX44qJEoxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LxtAFUjT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dQcPRL2H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LxtAFUjT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dQcPRL2H" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QAGgUq121454 for ; Wed, 26 Aug 2026 11:54:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kJXhURYbF22u5h3SNtJoh5SZFJhDJmU53UX6OeRXsy8=; b=LxtAFUjT3OLnYJSo iTXTYynpeMBZks3L4NGPbINgsPIJu/3jPEXJrSKSfDkvAvKsbOgS8/xA2pH/39Rj yy2dHdNl65obDPrQPNthxMCMAMWgHh884PzNFcJq4nm9LvoKh4XsgA66eT1Smh1r AXIulxLmeOEBewWZYQvqjjTXLgC+yyjIosqmLJImuEwzwtk4RStmdaAJiANAkP0V 1xjbgX7vtwHu0a0qX5p9DOuVIYsgr9KNd+A9Et/Oto7ZZmbAvd4euQCNwqFA4O2p eDfabYu69tKt10PyiZ60B4SJyK0M4vABOiJW6TOx8CkqbOwx8hGEUuuTRvWtum8T o5/1SQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9smx9msy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 11:54:56 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-85326b426c0so764992b3a.3 for ; Wed, 26 Aug 2026 04:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787745296; x=1788350096; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kJXhURYbF22u5h3SNtJoh5SZFJhDJmU53UX6OeRXsy8=; b=dQcPRL2HyYx1eLxkjH4eHTXn7P/ISmBL4ZnUtYZ1oynh7D0+JWr6EXuZA4k4Esr1Bc /GEYM313En+7Inr/w3VKZ3FHWmsOc/6NMHlQJ428N6UFuu5PrCn+Xa/bHWdRgyo4yp+o QfAeOw9Tg6A30MvoYwKDGEcUlnOTciey6luH198D+818TtBqciwN/g9SQorezdo0t+f3 EbtILsqL/0+Gc7fK5lkZ8XKRGfjMp4UFay15Zt+oOhnNpdi6PQTxo/H7YBpdPOQOoN4F okM7tIpgMJco+e8YUxYuO5yxKkzq/mnkOU1H1f6ckLbAp6FUwtcsz0XXVPKF9Ff8XxVB 5adQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787745296; x=1788350096; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kJXhURYbF22u5h3SNtJoh5SZFJhDJmU53UX6OeRXsy8=; b=NtnMj65ZwCL0dkifEKtkQW40xa9tFFcNnHs4kE2NJEMDFRPGVwT5pOwpdPFunfpfwK SeGTn4OXrOBpaVWRilXBlqFcLB1d/tC75uDZrPGzCmgroN5iFobU7hW71xXh6/Lejgy+ 300uWKoh9gKbTrp5+WlMZatOXWSL8IIUaBT4T0jls6XmcdrMDJDv/WOvuuIr44CHeI22 xpdE3NTzPBtdt1NPVoiBdt7sdVVWUp20FMnJnW2AGr0xm2bp38Li89cUhA+7kzs+W4pq qWvuQdvqS6mDWdZuD0/f0WcnmmfI7Jp+h5WivrTYoD/9M8o/8L1gUhIgERZpZCxpPTo2 uZXA== X-Forwarded-Encrypted: i=1; AHgh+RohhrPLq8dtn/BCgkXNCv6Fih4dvrwk1dZeraV68sS67T07uqvJILFCJvvDp2cGtvzkEWFAXEpKtYQ=@vger.kernel.org X-Gm-Message-State: AFuF++ncIqQjE2KLeZTtZ7kiHFMn3nwQKyajXHVBEiHi89hTo2GG844Q xFY7UXGaQtv9+H3NNotHb1YOY0EaYjLgEm7XDfO8ETuoh7MrXLT/4VVoWORfzS0olL1a1bzuMAa uZibCh96YQqXUXo2hhHiVi4sIgaWu7ACLIM+XrSRnOyLIbQkczkzORon0TYouko4= X-Gm-Gg: AR+sD10xs+M9ma8/IhWcf4wqx7/7ul06r2QuuYQD9pLILRLXH/HA/CYkRRJaticVKPu lbV4TJY8jVk4tdJ8N81aD/LS4xZdKqyXL52ArMDBMtDlOTqJTZh5ONJxsvggFtKtbche/10aCPC +ZU+KGDp8oBbhU2XS/01vbZ74tcbHYHba714SHbyxCJOvHgQRM1zcbW3JivcPSnYp8+ZJylBWAy +CN2yl6dIPVQFgV4QUsx3usMHBXbN2n6Loq6OoIFKsIsa2E07Vcap62Xfc0ogqoyw0z54iAT3G8 7W7UgViIFu8g/WGKVuE1bZmqgUAT2kTKBQGiWEHNCS0vMkY3roa31WYoDr6xn58WiLQFlGiYr8m xWIRQj4QMH6FK5Y7+mF4sj4eOUDCt9IabJxg= X-Received: by 2002:a05:6a00:6ca7:b0:848:2e7e:353a with SMTP id d2e1a72fcca58-8536ec13a78mr13481230b3a.0.1787745296230; Wed, 26 Aug 2026 04:54:56 -0700 (PDT) X-Received: by 2002:a05:6a00:6ca7:b0:848:2e7e:353a with SMTP id d2e1a72fcca58-8536ec13a78mr13481100b3a.0.1787745295712; Wed, 26 Aug 2026 04:54:55 -0700 (PDT) Received: from [10.217.219.186] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8535cf3e982sm793514b3a.54.2026.08.26.04.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 04:54:55 -0700 (PDT) Message-ID: <4efcdf15-286c-4bd6-a75f-77fbca07e7a4@oss.qualcomm.com> Date: Wed, 26 Aug 2026 17:24:48 +0530 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] i2c: qcom-geni: Use geni_se_set_rate() for setting source clock frequency To: Praveen Talari , konrad.dybcio@oss.qualcomm.com, Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-0-61171ab1cdce@oss.qualcomm.com> <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-7-61171ab1cdce@oss.qualcomm.com> <8af7a34a-da4f-492f-a51c-cc420edc5e6e@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=O/oJeh9W c=1 sm=1 tr=0 ts=6a8ed410 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=4Fh5LKrImxLeDWyZwEgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: w8oV23KPcTDer9jD7-hgduBsmaiUXNXO X-Proofpoint-ORIG-GUID: w8oV23KPcTDer9jD7-hgduBsmaiUXNXO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA5OSBTYWx0ZWRfXwdI7mx3XrIQW HlxR6LCKlevuw2DqqmIAKFlPREAyaUlVj48ik9I9Ijs37tR84xoSaGdcs8PhGIgIF7dwfx+beCG VyDbCz4xdgRUQbX7kgF1NZPOUdGRbh/5G7JNb03CGn0CMDxTFDU7M3ANX+tA/4w7xBnHKSUfIMN gv16Kz7KjRJ8rnp1zIGwVKzCaOQCPeCClBejWJpBjK+sphMdxgDTJ06KTvmtppuiAdvg5SlekId AR2ywOn/zgbJ+kCMbSD4/yLL7AbY5jmqk60DLMRdR1hmcJMzMbfFNbz9x4RyJhyj1dgujxqOu1F adSO7lqHNwWWzrV0xlI8wxkN6OqIMtdpaW5x4egeJ5uqwTz8Q9/tkwXyVODJYqXl+JLfexEmGrq QbX58e+452s7Oj9Qpk+p0BMbSd2t0z9dYd8DMKoamsNm4842pWYmpT+DFQ7b00iziHlZScbFybG Ov00Ui1Qi+qBppfiPww== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA5OSBTYWx0ZWRfX0XOwLi6ZRq4k I/ZIlXZRYMkaSACskg7jPPLcBFPLPRCC0ByVDMVDZ9CKH/SieqZdLqxSxqx8uFd9NU6rcXFkfXL MfcKcoBj+0qY+YitKWkpCUNhP7yZOzo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_03,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260099 On 8/25/2026 12:38 PM, Praveen Talari wrote: [...] >>> index a23554d101fd..4561e2d235d5 100644 >>> --- a/drivers/i2c/busses/i2c-qcom-geni.c >>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >>> @@ -213,11 +213,11 @@ static int geni_i2c_clk_map_idx(struct >>> geni_i2c_dev *gi2c) >>>       return -EINVAL; >>>   } >>>   -static int qcom_geni_i2c_conf(struct geni_se *se, unsigned long freq) >>> +static int qcom_geni_i2c_conf(struct geni_se *se) >>>   { >>>       struct geni_i2c_dev *gi2c = dev_get_drvdata(se->dev); >>>       const struct geni_i2c_clk_fld *itr = gi2c->clk_fld; >>> -    u32 val; >>> +    u32 val, ret; >>>         writel_relaxed(0, gi2c->se.base + SE_GENI_CLK_SEL); >>>   @@ -233,6 +233,10 @@ static int qcom_geni_i2c_conf(struct geni_se >>> *se, unsigned long freq) >>>                    itr->clk_div, itr->t_high_cnt, >>>                    itr->t_low_cnt, itr->t_cycle_cnt); >>>   +    ret = geni_se_set_rate(&gi2c->se, 19200000); >> >> hard code ? > > Good point. The 19.2 MHz value is not intended to be a permanent > limitation. > > This matches the frequency currently used by the I2C driver and > therefore preserves > > the existing behavior. If support for higher source clock frequencies > (e.g. 32 MHz or others) > This is already added in driver for 32 MHz and also AFAIK, support is added for 3.4 MHZ which considers 100Mhz. so make it something which is generic. Hard code is not recommended here. Can we store source freq selection and continue with that ? > is added in the future, the requested OPP/performance state will need to > be updated accordingly. > > >> May work currently, but if higher frequency support added, source may >> change. >> >> Also you have added in commit message, but add a comment also here. >> [...]