From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] spi: Add support for specifing 3-wire mode via device tree Date: Fri, 13 Jul 2012 07:44:58 -0500 Message-ID: <5000184A.2000600@gmail.com> References: <1342183427-23430-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Michael Hennerich To: Lars-Peter Clausen Return-path: In-Reply-To: <1342183427-23430-1-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" List-Id: linux-spi.vger.kernel.org On 07/13/2012 07:43 AM, Lars-Peter Clausen wrote: > This patch allows to specify that a SPI device is connected in 3-wire mode via > the device tree. > > Signed-off-by: Lars-Peter Clausen > --- Might explain what 3-wire mode is, but otherwise Acked-by: Rob Herring > Documentation/devicetree/bindings/spi/spi-bus.txt | 2 ++ > drivers/spi/spi.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt > index e782add..46f2f3b 100644 > --- a/Documentation/devicetree/bindings/spi/spi-bus.txt > +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt > @@ -33,6 +33,8 @@ contain the following properties. > shifted clock phase (CPHA) mode > - spi-cs-high - (optional) Empty property indicating device requires > chip select active high > +- spi-3wire - (optional) Empty property indicating device requires > + 3-wire mode. > > SPI example for an MPC5200 SPI bus: > spi@f00 { > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index fc0da39..09da7de 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -856,6 +856,8 @@ static void of_register_spi_devices(struct spi_master *master) > spi->mode |= SPI_CPOL; > if (of_find_property(nc, "spi-cs-high", NULL)) > spi->mode |= SPI_CS_HIGH; > + if (of_find_property(nc, "spi-3wire", NULL)) > + spi->mode |= SPI_3WIRE; > > /* Device speed */ > prop = of_get_property(nc, "spi-max-frequency", &len); >