From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] spi: spi-altera: Use of_match_ptr Date: Wed, 15 Aug 2012 08:09:07 -0500 Message-ID: <502B9F73.4040508@gmail.com> References: <1345015828-8444-1-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "Mark Brown \(broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org\)" To: Tobias Klauser Return-path: In-Reply-To: <1345015828-8444-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 08/15/2012 02:30 AM, Tobias Klauser wrote: > Instead of having to define the match table to NULL if CONFIG_OF isn't > set, use the of_match_ptr() macro which will do this for us. > > Signed-off-by: Tobias Klauser Acked-by: Rob Herring Adding Mark B. as he is helping Grant out with spi. Rob > --- > drivers/spi/spi-altera.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c > index c00d00e..f1fec2a 100644 > --- a/drivers/spi/spi-altera.c > +++ b/drivers/spi/spi-altera.c > @@ -307,8 +307,6 @@ static const struct of_device_id altera_spi_match[] = { > {}, > }; > MODULE_DEVICE_TABLE(of, altera_spi_match); > -#else /* CONFIG_OF */ > -#define altera_spi_match NULL > #endif /* CONFIG_OF */ > > static struct platform_driver altera_spi_driver = { > @@ -318,7 +316,7 @@ static struct platform_driver altera_spi_driver = { > .name = DRV_NAME, > .owner = THIS_MODULE, > .pm = NULL, > - .of_match_table = altera_spi_match, > + .of_match_table = of_match_ptr(altera_spi_match), > }, > }; > module_platform_driver(altera_spi_driver); > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/