From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Stigge Subject: Re: [PATCH RESEND v4] spi/pl022: add devicetree support Date: Mon, 20 Aug 2012 17:33:34 +0200 Message-ID: <503258CE.9030106@antcom.de> References: <1345462769-17386-1-git-send-email-aletes.xgr@gmail.com> <50324835.6030806@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Alexandre Pereira da Silva , Grant Likely , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net, "Mark Brown (broonie@opensource.wolfsonmicro.com)" , Linus Walleij , devicetree-discuss@lists.ozlabs.org To: Rob Herring Return-path: In-Reply-To: <50324835.6030806@gmail.com> Sender: linux-doc-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On 08/20/2012 04:22 PM, Rob Herring wrote: >> .../devicetree/bindings/spi/spi_pl022.txt | 15 +++ >> drivers/spi/spi-pl022.c | 114 ++++++++++++++++---- >> 2 files changed, 110 insertions(+), 19 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt >> index 306ec3f..b089ec7 100644 >> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt >> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt >> @@ -6,7 +6,22 @@ Required properties: >> - interrupts : Should contain SPI controller interrupt >> >> Optional properties: >> +- pl022,num-chipselects : total number of chipselects > > We have this for other spi controllers too. Define a generic property. Currently, we have: num-cs ti,spi-num-cs fsl,spi-num-chipselects fsl,espi-num-chipselects (pl022,num-chipselects) Would "num-cs" be the right one to use? Thanks, Roland